You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by rg...@apache.org on 2014/07/31 19:10:18 UTC
svn commit: r1614938 - in /qpid/trunk/qpid/java:
broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObject.java
broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/RestServlet.java
Author: rgodfrey
Date: Thu Jul 31 17:10:17 2014
New Revision: 1614938
URL: http://svn.apache.org/r1614938
Log:
QPID-5937 : Address comments from ~k-wall
Modified:
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObject.java
qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/RestServlet.java
Modified: qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObject.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObject.java?rev=1614938&r1=1614937&r2=1614938&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObject.java (original)
+++ qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObject.java Thu Jul 31 17:10:17 2014
@@ -79,7 +79,7 @@ public interface ConfiguredObject<X exte
<T> T getContextValue(Class<T> clazz, String propertyName);
- Set<String> getContextKeys(final boolean includeSystem);
+ Set<String> getContextKeys(final boolean excludeSystem);
@DerivedAttribute( persist = true )
String getLastUpdatedBy();
Modified: qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/RestServlet.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/RestServlet.java?rev=1614938&r1=1614937&r2=1614938&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/RestServlet.java (original)
+++ qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/RestServlet.java Thu Jul 31 17:10:17 2014
@@ -621,20 +621,7 @@ public class RestServlet extends Abstrac
private boolean getBooleanParameterFromRequest(HttpServletRequest request, final String paramName)
{
- boolean value = false;
- final String stringValue = request.getParameter(paramName);
- if(stringValue!=null)
- {
- try
- {
- value = Boolean.parseBoolean(stringValue);
- }
- catch (NumberFormatException e)
- {
- LOGGER.warn("Could not parse " + stringValue + " as integer");
- }
- }
- return value;
+ return Boolean.parseBoolean(request.getParameter(paramName));
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org