You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/03 07:58:17 UTC
[GitHub] [superset] waynewenswag opened a new pull request, #22020: feat(helm): add `metadata namespace`
waynewenswag opened a new pull request, #22020:
URL: https://github.com/apache/superset/pull/22020
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Add `metadata.namespace` to deploy with kustomize
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] waynewenswag commented on pull request #22020: feat(helm): add `metadata namespace`
Posted by GitBox <gi...@apache.org>.
waynewenswag commented on PR #22020:
URL: https://github.com/apache/superset/pull/22020#issuecomment-1308311015
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #22020: feat(helm): add `metadata namespace`
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on PR #22020:
URL: https://github.com/apache/superset/pull/22020#issuecomment-1307719284
@Yann-J - any idea why CI is failing here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] waynewenswag commented on pull request #22020: feat(helm): add `metadata namespace`
Posted by GitBox <gi...@apache.org>.
waynewenswag commented on PR #22020:
URL: https://github.com/apache/superset/pull/22020#issuecomment-1303135789
Added and thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #22020: feat(helm): add `metadata namespace`
Posted by GitBox <gi...@apache.org>.
craig-rueda merged PR #22020:
URL: https://github.com/apache/superset/pull/22020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Yann-J commented on pull request #22020: feat(helm): add `metadata namespace`
Posted by GitBox <gi...@apache.org>.
Yann-J commented on PR #22020:
URL: https://github.com/apache/superset/pull/22020#issuecomment-1308296460
Yeah, the new `helm-docs` pre-commit hook failed, because the version was bumped but the `README` was not updated to reflect that.
@waynewenswag I cannot push to your branch to fix it, but all you need is to run all pre-commit checks with `pre-commit run --all`.
You may need to install/update them or their dependencies first of course:
```
# install helm-docs
brew install norwoodj/tap/helm-docs
# install all hooks
pre-commit install-hooks
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #22020: feat(helm): add `metadata namespace`
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on PR #22020:
URL: https://github.com/apache/superset/pull/22020#issuecomment-1309204835
Awesome, thanks @Yann-J !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org