You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Carlin Rogers (JIRA)" <be...@incubator.apache.org> on 2005/05/06 19:24:06 UTC
[jira] Created: (BEEHIVE-610) XmlHttpRequestServlet does not register a default URLRewriter
XmlHttpRequestServlet does not register a default URLRewriter
-------------------------------------------------------------
Key: BEEHIVE-610
URL: http://issues.apache.org/jira/browse/BEEHIVE-610
Project: Beehive
Type: Bug
Components: NetUI
Versions: V1
Reporter: Carlin Rogers
Assigned to: Carlin Rogers
Priority: Minor
Fix For: TBD
Attachments: xhrpatch.txt
Here's something I noticed while looking at JIRA Beehive-609.
The XmlHttpRequestServlet does not register a default URLRewriter with
the URLRewriterService. In other NetUI request handling, such as the
PageFlowRequestProcessor and PageFlowPageFilter, we always register the
default URLRewriter.
This is a minor issue as currently the DefaultURLRewriter implementation
or getNamePrefix() is a noop. However, the rewriteURL() does handle
some secure/unsecure rewriting. It might be good to get this in for 1.0.
The fix is very easy and I feel is low risk. We just add the following
line to XmlHttpRequestServlet.doGet() to handle the registration before
handing off to the request interceptors.
// Register the default URLRewriter
URLRewriterService.registerURLRewriter(0, request, new
DefaultURLRewriter());
I will attach a patch and let committers determine if this should
go into 1.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (BEEHIVE-610) XmlHttpRequestServlet does not register a default URLRewriter
Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-610?page=all ]
Rich Feit resolved BEEHIVE-610:
-------------------------------
Assign To: Carlin Rogers (was: Rich Feit)
Resolution: Fixed
Fix Version: V1
(was: TBD)
Applied the patch with revision 169493 -- thanks.
> XmlHttpRequestServlet does not register a default URLRewriter
> -------------------------------------------------------------
>
> Key: BEEHIVE-610
> URL: http://issues.apache.org/jira/browse/BEEHIVE-610
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1
> Reporter: Carlin Rogers
> Assignee: Carlin Rogers
> Priority: Minor
> Fix For: V1
> Attachments: xhrpatch.txt
>
> Here's something I noticed while looking at JIRA Beehive-609.
> The XmlHttpRequestServlet does not register a default URLRewriter with
> the URLRewriterService. In other NetUI request handling, such as the
> PageFlowRequestProcessor and PageFlowPageFilter, we always register the
> default URLRewriter.
> This is a minor issue as currently the DefaultURLRewriter implementation
> or getNamePrefix() is a noop. However, the rewriteURL() does handle
> some secure/unsecure rewriting. It might be good to get this in for 1.0.
> The fix is very easy and I feel is low risk. We just add the following
> line to XmlHttpRequestServlet.doGet() to handle the registration before
> handing off to the request interceptors.
> // Register the default URLRewriter
> URLRewriterService.registerURLRewriter(0, request, new
> DefaultURLRewriter());
> I will attach a patch and let committers determine if this should
> go into 1.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (BEEHIVE-610) XmlHttpRequestServlet does not register a default URLRewriter
Posted by "Carlin Rogers (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-610?page=all ]
Carlin Rogers closed BEEHIVE-610:
---------------------------------
verified the code change from the patch. thanks!
> XmlHttpRequestServlet does not register a default URLRewriter
> -------------------------------------------------------------
>
> Key: BEEHIVE-610
> URL: http://issues.apache.org/jira/browse/BEEHIVE-610
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1
> Reporter: Carlin Rogers
> Assignee: Carlin Rogers
> Priority: Minor
> Fix For: V1
> Attachments: xhrpatch.txt
>
> Here's something I noticed while looking at JIRA Beehive-609.
> The XmlHttpRequestServlet does not register a default URLRewriter with
> the URLRewriterService. In other NetUI request handling, such as the
> PageFlowRequestProcessor and PageFlowPageFilter, we always register the
> default URLRewriter.
> This is a minor issue as currently the DefaultURLRewriter implementation
> or getNamePrefix() is a noop. However, the rewriteURL() does handle
> some secure/unsecure rewriting. It might be good to get this in for 1.0.
> The fix is very easy and I feel is low risk. We just add the following
> line to XmlHttpRequestServlet.doGet() to handle the registration before
> handing off to the request interceptors.
> // Register the default URLRewriter
> URLRewriterService.registerURLRewriter(0, request, new
> DefaultURLRewriter());
> I will attach a patch and let committers determine if this should
> go into 1.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (BEEHIVE-610) XmlHttpRequestServlet does not register a default URLRewriter
Posted by "Carlin Rogers (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-610?page=all ]
Carlin Rogers reassigned BEEHIVE-610:
-------------------------------------
Assign To: Rich Feit (was: Carlin Rogers)
Assigning to Rich to review this patch either for
1.0 or post 1.0, as appropriate. Thanks.
> XmlHttpRequestServlet does not register a default URLRewriter
> -------------------------------------------------------------
>
> Key: BEEHIVE-610
> URL: http://issues.apache.org/jira/browse/BEEHIVE-610
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1
> Reporter: Carlin Rogers
> Assignee: Rich Feit
> Priority: Minor
> Fix For: TBD
> Attachments: xhrpatch.txt
>
> Here's something I noticed while looking at JIRA Beehive-609.
> The XmlHttpRequestServlet does not register a default URLRewriter with
> the URLRewriterService. In other NetUI request handling, such as the
> PageFlowRequestProcessor and PageFlowPageFilter, we always register the
> default URLRewriter.
> This is a minor issue as currently the DefaultURLRewriter implementation
> or getNamePrefix() is a noop. However, the rewriteURL() does handle
> some secure/unsecure rewriting. It might be good to get this in for 1.0.
> The fix is very easy and I feel is low risk. We just add the following
> line to XmlHttpRequestServlet.doGet() to handle the registration before
> handing off to the request interceptors.
> // Register the default URLRewriter
> URLRewriterService.registerURLRewriter(0, request, new
> DefaultURLRewriter());
> I will attach a patch and let committers determine if this should
> go into 1.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (BEEHIVE-610) XmlHttpRequestServlet does not register a default URLRewriter
Posted by "Carlin Rogers (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-610?page=all ]
Carlin Rogers updated BEEHIVE-610:
----------------------------------
Attachment: xhrpatch.txt
Here's the patch to modify XmlHttpRequestServlet.doget() and add
the line to register a DefaultURLRewriter instance with the
URLRewriterService.
> XmlHttpRequestServlet does not register a default URLRewriter
> -------------------------------------------------------------
>
> Key: BEEHIVE-610
> URL: http://issues.apache.org/jira/browse/BEEHIVE-610
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1
> Reporter: Carlin Rogers
> Assignee: Carlin Rogers
> Priority: Minor
> Fix For: TBD
> Attachments: xhrpatch.txt
>
> Here's something I noticed while looking at JIRA Beehive-609.
> The XmlHttpRequestServlet does not register a default URLRewriter with
> the URLRewriterService. In other NetUI request handling, such as the
> PageFlowRequestProcessor and PageFlowPageFilter, we always register the
> default URLRewriter.
> This is a minor issue as currently the DefaultURLRewriter implementation
> or getNamePrefix() is a noop. However, the rewriteURL() does handle
> some secure/unsecure rewriting. It might be good to get this in for 1.0.
> The fix is very easy and I feel is low risk. We just add the following
> line to XmlHttpRequestServlet.doGet() to handle the registration before
> handing off to the request interceptors.
> // Register the default URLRewriter
> URLRewriterService.registerURLRewriter(0, request, new
> DefaultURLRewriter());
> I will attach a patch and let committers determine if this should
> go into 1.0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira