[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #8967: Clean scroll context

[GitBox <gi...@apache.org>]

kezhenxu94 commented on code in PR #8967:
URL: https://github.com/apache/skywalking/pull/8967#discussion_r860463732


##########
docs/en/changes/changes.md:
##########
@@ -30,6 +30,7 @@
 * Add data-generator module to run OAP in testing mode, generating mock data for testing.
 * Support receive Kubernetes processes from gRPC protocol.
 * Fix the problem that es index(TimeSeriesTable, eg. endpoint_traffic, alarm_record) didn't create even after rerun with init-mode. This problem caused the OAP server to fail to start when the OAP server was down for more than a day.
+* Clean up scroll contexts after used.

Review Comment:
   Usually this is not a critical problem as the context has an expiration time (30s), but in high volume of clusters (millions of service /network aliases that the all results cannot be retrieved within the expiration time) this would cause
   
   ```
   Trying to create too many scroll contexts. Must be less than or equal to: [500]. This limit can be set by changing the [search.max_open_scroll_context] setting
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org