You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Chris Bartlett (JIRA)" <ji...@apache.org> on 2010/12/03 21:29:29 UTC

[jira] Created: (PIVOT-679) TableViewImageCellRenderer should render disabled rows with an opacity of 0.5f

TableViewImageCellRenderer should render disabled rows with an opacity of 0.5f
------------------------------------------------------------------------------

                 Key: PIVOT-679
                 URL: https://issues.apache.org/jira/browse/PIVOT-679
             Project: Pivot
          Issue Type: Improvement
          Components: wtk
         Environment: n/a
            Reporter: Chris Bartlett
            Priority: Trivial
             Fix For: 2.1


All of the following renderers set the ImageView's opacity to 0.5f when the relevant item is disabled.   
TableViewImageCellRenderer should do the same for consistency.

ButtonDataRenderer
LinkButtonDataRenderer
ListViewItemRenderer
MenuBarItemDataRenderer
MenuItemDataRenderer
TableViewHeaderDataRenderer 
TreeViewNodeRenderer


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Assigned] (PIVOT-679) TableViewImageCellRenderer should render disabled rows with an opacity of 0.5f

Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Whitcomb reassigned PIVOT-679:
------------------------------------

    Assignee: Roger Whitcomb  (was: Chris Bartlett)
    
> TableViewImageCellRenderer should render disabled rows with an opacity of 0.5f
> ------------------------------------------------------------------------------
>
>                 Key: PIVOT-679
>                 URL: https://issues.apache.org/jira/browse/PIVOT-679
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>         Environment: n/a
>            Reporter: Chris Bartlett
>            Assignee: Roger Whitcomb
>            Priority: Trivial
>             Fix For: 2.1
>
>
> All of the following renderers set the ImageView's opacity to 0.5f when the relevant item is disabled.   
> TableViewImageCellRenderer should do the same for consistency.
> ButtonDataRenderer
> LinkButtonDataRenderer
> ListViewItemRenderer
> MenuBarItemDataRenderer
> MenuItemDataRenderer
> TableViewHeaderDataRenderer 
> TreeViewNodeRenderer

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (PIVOT-679) TableViewImageCellRenderer should render disabled rows with an opacity of 0.5f

Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966665#action_12966665 ] 

Greg Brown commented on PIVOT-679:
----------------------------------

Possibly. If we do this, we should also ensure that the text-based renderers draw "grayed out" text using the disabled color in this case. I don't remember if they are coded that way now or not.



> TableViewImageCellRenderer should render disabled rows with an opacity of 0.5f
> ------------------------------------------------------------------------------
>
>                 Key: PIVOT-679
>                 URL: https://issues.apache.org/jira/browse/PIVOT-679
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>         Environment: n/a
>            Reporter: Chris Bartlett
>            Priority: Trivial
>             Fix For: 2.1
>
>
> All of the following renderers set the ImageView's opacity to 0.5f when the relevant item is disabled.   
> TableViewImageCellRenderer should do the same for consistency.
> ButtonDataRenderer
> LinkButtonDataRenderer
> ListViewItemRenderer
> MenuBarItemDataRenderer
> MenuItemDataRenderer
> TableViewHeaderDataRenderer 
> TreeViewNodeRenderer

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Commented] (PIVOT-679) TableViewImageCellRenderer should render disabled rows with an opacity of 0.5f

Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424170#comment-13424170 ] 

Roger Whitcomb commented on PIVOT-679:
--------------------------------------

The default TableViewCellRenderer definitely uses the disabled color for the text if the row is disabled.  And this includes the classes derived from it (Date, FileSize, Number) which don't override the "render" method.  The TableViewTextAreaCellRenderer uses a similar methodology, so it also uses the disabled color.  The checkbox renderer sets the enabled state of its checkbox, so that should work too.

So, it looks like this renderer is the only holdout.  Assigning this issue to me -- I have the code almost ready.
                
> TableViewImageCellRenderer should render disabled rows with an opacity of 0.5f
> ------------------------------------------------------------------------------
>
>                 Key: PIVOT-679
>                 URL: https://issues.apache.org/jira/browse/PIVOT-679
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>         Environment: n/a
>            Reporter: Chris Bartlett
>            Assignee: Chris Bartlett
>            Priority: Trivial
>             Fix For: 2.1
>
>
> All of the following renderers set the ImageView's opacity to 0.5f when the relevant item is disabled.   
> TableViewImageCellRenderer should do the same for consistency.
> ButtonDataRenderer
> LinkButtonDataRenderer
> ListViewItemRenderer
> MenuBarItemDataRenderer
> MenuItemDataRenderer
> TableViewHeaderDataRenderer 
> TreeViewNodeRenderer

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIVOT-679) TableViewImageCellRenderer should render disabled rows with an opacity of 0.5f

Posted by "Chris Bartlett (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Bartlett updated PIVOT-679:
---------------------------------

    Assignee: Chris Bartlett

> TableViewImageCellRenderer should render disabled rows with an opacity of 0.5f
> ------------------------------------------------------------------------------
>
>                 Key: PIVOT-679
>                 URL: https://issues.apache.org/jira/browse/PIVOT-679
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>         Environment: n/a
>            Reporter: Chris Bartlett
>            Assignee: Chris Bartlett
>            Priority: Trivial
>             Fix For: 2.1
>
>
> All of the following renderers set the ImageView's opacity to 0.5f when the relevant item is disabled.   
> TableViewImageCellRenderer should do the same for consistency.
> ButtonDataRenderer
> LinkButtonDataRenderer
> ListViewItemRenderer
> MenuBarItemDataRenderer
> MenuItemDataRenderer
> TableViewHeaderDataRenderer 
> TreeViewNodeRenderer

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (PIVOT-679) TableViewImageCellRenderer should render disabled rows with an opacity of 0.5f

Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Whitcomb resolved PIVOT-679.
----------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.1)
                   2.0.3

trunk:
Sending        wtk/src/org/apache/pivot/wtk/content/TableViewImageCellRenderer.java
Transmitting file data .
Committed revision 1366553.

2.0.x:
Sending        wtk/src/org/apache/pivot/wtk/content/TableViewImageCellRenderer.java
Transmitting file data .
Committed revision 1366556.

                
> TableViewImageCellRenderer should render disabled rows with an opacity of 0.5f
> ------------------------------------------------------------------------------
>
>                 Key: PIVOT-679
>                 URL: https://issues.apache.org/jira/browse/PIVOT-679
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>         Environment: n/a
>            Reporter: Chris Bartlett
>            Assignee: Roger Whitcomb
>            Priority: Trivial
>             Fix For: 2.0.3
>
>
> All of the following renderers set the ImageView's opacity to 0.5f when the relevant item is disabled.   
> TableViewImageCellRenderer should do the same for consistency.
> ButtonDataRenderer
> LinkButtonDataRenderer
> ListViewItemRenderer
> MenuBarItemDataRenderer
> MenuItemDataRenderer
> TableViewHeaderDataRenderer 
> TreeViewNodeRenderer

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira