You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/19 12:46:18 UTC

[GitHub] [arrow-datafusion] jackwener commented on issue #2271: Inner join incorrectly pushdown predicate with OR operation

jackwener commented on issue #2271:
URL: https://github.com/apache/arrow-datafusion/issues/2271#issuecomment-1102600707

   😅 `optimizer` of datafusion is strange.....We should put the `convert outer join to inner/right/left join` in the `rule`.
   
   We can infer `is not null` in the `on clause` or `where clause` and `is not null` can make `outer join` convert.
   
   Current:
   - `convert join` with `on clause` is in `parse_join() in `plan_from_tables()`
   - `convert join` with `where clause` is in `plan_selection()`
   
   This bug is because `parse_join()` use the cols from `extract_join_keys` directly. It's wrong.
   
   I have explained them carefully in https://github.com/apache/incubator-doris/pull/8910#issuecomment-1096159553
   
   Easy way is just consider `AND`. 
   
   Hope those information is helpful to person who want to fix this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org