You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/07/25 02:48:50 UTC

[kudu-CR] KUDU-2376 re-enable ReplaceTabletsWhileWriting scenario

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21612


Change subject: KUDU-2376 re-enable ReplaceTabletsWhileWriting scenario
......................................................................

KUDU-2376 re-enable ReplaceTabletsWhileWriting scenario

Since KUDU-2376 seems to be a duplicate of KUDU-3461, and the latter
has already been addressed, it makes sense to re-enable the
ReplaceTabletITest.ReplaceTabletsWhileWriting scenario which is
now passing with this patch.

TestWorkload updated to allow for Status::InvalidAgrument status
that percolates from the client's meta-cache when a tablet is replaced.
This patch also contains other minor (mostly cosmetic) updates.

Change-Id: I36b0e69022f07dd701a91e72e16c93f134d00619
---
M src/kudu/client/client-test.cc
M src/kudu/client/meta_cache.cc
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/replace_tablet-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
6 files changed, 37 insertions(+), 25 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/21612/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I36b0e69022f07dd701a91e72e16c93f134d00619
Gerrit-Change-Number: 21612
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] KUDU-2376 re-enable ReplaceTabletsWhileWriting scenario

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21612 )

Change subject: KUDU-2376 re-enable ReplaceTabletsWhileWriting scenario
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/330/


-- 
To view, visit http://gerrit.cloudera.org:8080/21612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b0e69022f07dd701a91e72e16c93f134d00619
Gerrit-Change-Number: 21612
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Jul 2024 02:48:59 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21612 )

Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario
......................................................................

[tests] re-enable ReplaceTabletsWhileWriting scenario

Since KUDU-2376 seems to be a duplicate of KUDU-3461, and the latter
has already been addressed, it makes sense to re-enable the
ReplaceTabletITest.ReplaceTabletsWhileWriting scenario which is
now passing with this patch.

TestWorkload updated to allow for Status::InvalidAgrument status
that percolates from the client's meta-cache when a tablet is replaced.
This patch also contains other minor (mostly cosmetic) updates.

Change-Id: I36b0e69022f07dd701a91e72e16c93f134d00619
Reviewed-on: http://gerrit.cloudera.org:8080/21612
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Ashwani Raina <ar...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/client/client-test.cc
M src/kudu/client/meta_cache.cc
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/replace_tablet-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
6 files changed, 37 insertions(+), 25 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Ashwani Raina: Looks good to me, but someone else must approve
  Abhishek Chennaka: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/21612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I36b0e69022f07dd701a91e72e16c93f134d00619
Gerrit-Change-Number: 21612
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21612 )

Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario
......................................................................


Patch Set 2: Verified+1

TSAN: unrelated tests failures.  Filed KUDU-3596, KUDU-3597, KUDU-3598


-- 
To view, visit http://gerrit.cloudera.org:8080/21612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b0e69022f07dd701a91e72e16c93f134d00619
Gerrit-Change-Number: 21612
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Jul 2024 05:20:32 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21612 )

Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario
......................................................................


Patch Set 1:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/330/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/21612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b0e69022f07dd701a91e72e16c93f134d00619
Gerrit-Change-Number: 21612
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Jul 2024 02:50:01 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21612 )

Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b0e69022f07dd701a91e72e16c93f134d00619
Gerrit-Change-Number: 21612
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Jul 2024 17:47:33 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/21612 )

Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b0e69022f07dd701a91e72e16c93f134d00619
Gerrit-Change-Number: 21612
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Jul 2024 13:10:07 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Ashwani Raina, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21612

to look at the new patch set (#2).

Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario
......................................................................

[tests] re-enable ReplaceTabletsWhileWriting scenario

Since KUDU-2376 seems to be a duplicate of KUDU-3461, and the latter
has already been addressed, it makes sense to re-enable the
ReplaceTabletITest.ReplaceTabletsWhileWriting scenario which is
now passing with this patch.

TestWorkload updated to allow for Status::InvalidAgrument status
that percolates from the client's meta-cache when a tablet is replaced.
This patch also contains other minor (mostly cosmetic) updates.

Change-Id: I36b0e69022f07dd701a91e72e16c93f134d00619
---
M src/kudu/client/client-test.cc
M src/kudu/client/meta_cache.cc
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/replace_tablet-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
6 files changed, 37 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/21612/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36b0e69022f07dd701a91e72e16c93f134d00619
Gerrit-Change-Number: 21612
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21612 )

Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/331/


-- 
To view, visit http://gerrit.cloudera.org:8080/21612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b0e69022f07dd701a91e72e16c93f134d00619
Gerrit-Change-Number: 21612
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Jul 2024 02:50:09 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21612 )

Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/331/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b0e69022f07dd701a91e72e16c93f134d00619
Gerrit-Change-Number: 21612
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Jul 2024 03:57:14 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I36b0e69022f07dd701a91e72e16c93f134d00619
Gerrit-Change-Number: 21612
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)