You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/08/23 05:38:04 UTC
[Impala-ASF-CR](branch-4.1.1) IMPALA-11391: Fixed race condition in test drop managed kudu table
Hello Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/18893
to review the following change.
Change subject: IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
......................................................................
IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
test_drop_managed_kudu_table uses exception to verify the deleted table
is really missing. Depending on timing, this exception could have been
raised in several control pathes with different content. Now the test
waits for event processing, meaning Analyzer will consistently catch
the missing table and raise the same exception.
Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Reviewed-on: http://gerrit.cloudera.org:8080/18667
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_kudu.py
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/18893/1
--
To view, visit http://gerrit.cloudera.org:8080/18893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: newchange
Gerrit-Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Gerrit-Change-Number: 18893
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](branch-4.1.1) IMPALA-11391: Fixed race condition in test drop managed kudu table
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18893 )
Change subject: IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
......................................................................
Patch Set 1: Verified+1
Verified in https://jenkins.impala.io/job/gerrit-verify-dryrun/8490/
--
To view, visit http://gerrit.cloudera.org:8080/18893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Gerrit-Change-Number: 18893
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 22:22:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](branch-4.1.1) IMPALA-11391: Fixed race condition in test drop managed kudu table
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18893 )
Change subject: IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
......................................................................
Patch Set 1: Code-Review+2
+2 since this is a trivial test fix and clean cherrypick
--
To view, visit http://gerrit.cloudera.org:8080/18893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Gerrit-Change-Number: 18893
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 22:22:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](branch-4.1.1) IMPALA-11391: Fixed race condition in test drop managed kudu table
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18893 )
Change subject: IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
......................................................................
Patch Set 1:
This is a clean cherrypick.
--
To view, visit http://gerrit.cloudera.org:8080/18893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Gerrit-Change-Number: 18893
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 05:40:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](branch-4.1.1) IMPALA-11391: Fixed race condition in test drop managed kudu table
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18893 )
Change subject: IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
......................................................................
IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
test_drop_managed_kudu_table uses exception to verify the deleted table
is really missing. Depending on timing, this exception could have been
raised in several control pathes with different content. Now the test
waits for event processing, meaning Analyzer will consistently catch
the missing table and raise the same exception.
Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Reviewed-on: http://gerrit.cloudera.org:8080/18667
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/18893
Tested-by: Quanlong Huang <hu...@gmail.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
---
M tests/custom_cluster/test_kudu.py
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Quanlong Huang: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: merged
Gerrit-Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Gerrit-Change-Number: 18893
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>