You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2018/06/07 03:37:40 UTC
[GitHub] carbondata pull request #2363: [WIP][CARBONDATA-2591] SDK CarbonReader suppo...
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2363
[WIP][CARBONDATA-2591] SDK CarbonReader support filter
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
NO
- [ ] Any backward compatibility impacted?
No
- [ ] Document update required?
Yes
- [ ] Testing done
add some test case
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata CARBONDATA-2591-CarbonReaderFilter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2363.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2363
----
commit f7407681697be7570089c9936ecc9df1f457af63
Author: xubo245 <xu...@...>
Date: 2018-06-07T03:34:56Z
[CARBONDATA-2591] SDK CarbonReader support filter
----
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2363
retest this please
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2363
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5240/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6271/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6293/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2363
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5261/
---
[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r193979794
--- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
@@ -218,6 +222,41 @@ public static void updateTableInfo(TableInfo tableInfo) {
}
}
+ public static CarbonTable buildDummyTable(
--- End diff --
no need table name and db name to build table info when non filter
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2363
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5241/
---
[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r194324248
--- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -105,6 +115,243 @@ public void testWriteAndReadFiles() throws IOException, InterruptedException {
FileUtils.deleteDirectory(new File(path));
}
+ @Test
+ public void testReadWithFilterOfTransactional() throws IOException, InterruptedException {
--- End diff --
I think we should add test case for Transactional table , ensure the Transactional table is available too
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5126/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6277/
---
[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r193953785
--- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
@@ -218,6 +222,41 @@ public static void updateTableInfo(TableInfo tableInfo) {
}
}
+ public static CarbonTable buildDummyTable(
+ String tablePath,
+ String tableName,
+ String dbName,
+ boolean hasFilter) throws IOException {
+ TableInfo tableInfoInfer = CarbonUtil.buildDummyTableInfo(tablePath, tableName, dbName);
--- End diff --
what is the use of creating dummy table if alreday creating actual table down?
---
[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r193979695
--- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
@@ -218,6 +222,41 @@ public static void updateTableInfo(TableInfo tableInfo) {
}
}
+ public static CarbonTable buildDummyTable(
+ String tablePath,
+ String tableName,
+ String dbName,
+ boolean hasFilter) throws IOException {
+ TableInfo tableInfoInfer = CarbonUtil.buildDummyTableInfo(tablePath, tableName, dbName);
--- End diff --
removed the tableName and dbName
---
[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r193953877
--- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
@@ -218,6 +222,41 @@ public static void updateTableInfo(TableInfo tableInfo) {
}
}
+ public static CarbonTable buildDummyTable(
--- End diff --
I think it is not a dummy table. it is actual table.
---
[GitHub] carbondata issue #2363: [WIP][CARBONDATA-2591] SDK CarbonReader support filt...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6269/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6302/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5115/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2363
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5254/
---
[GitHub] carbondata issue #2363: [WIP][CARBONDATA-2591] SDK CarbonReader support filt...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6266/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2363
retest this please
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2363
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5243/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6281/
---
[GitHub] carbondata issue #2363: [CARBONDATA-2591] Fix SDK CarbonReader filter issue
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6270/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2363
@ravipesala : please merge this fix to 1.4.0 branch also
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6287/
---
[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r194382421
--- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
@@ -218,6 +222,40 @@ public static void updateTableInfo(TableInfo tableInfo) {
}
}
+ public static CarbonTable buildTable(
+ String tablePath,
+ String tableName,
+ boolean hasFilter) throws IOException {
--- End diff --
There should not be any filter related flags in Carbon Table API, if you require this check then move to utilities. It should only has buildTable method not `hasFilter` flag.
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2363
LGTM.
This fix need to merge to both master and 1.4 branch
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5109/
---
[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2363
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6273/
---
[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r194595227
--- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
@@ -218,6 +222,40 @@ public static void updateTableInfo(TableInfo tableInfo) {
}
}
+ public static CarbonTable buildTable(
+ String tablePath,
+ String tableName,
+ boolean hasFilter) throws IOException {
--- End diff --
ok.done
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5120/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6301/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2363
LGTM
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5112/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6274/
---
[GitHub] carbondata issue #2363: [CARBONDATA-2591] Fix SDK CarbonReader filter issue
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5107/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5138/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2363
retest this please
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6283/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6288/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2363
retest this please
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2363
retest this please
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2363
retest this please
---
[GitHub] carbondata issue #2363: [CARBONDATA-2591] Fix SDK CarbonReader filter issue
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5108/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5119/
---
[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r194334876
--- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java ---
@@ -179,7 +179,11 @@ public CarbonReaderBuilder setEndPoint(String value) {
if (isTransactionalTable) {
table = CarbonTable.buildFromTablePath(tableName, "default", tablePath);
} else {
- table = CarbonTable.buildDummyTable(tablePath);
+ if (filterExpression != null) {
+ table = CarbonTable.buildTable(tablePath, tableName, true);
+ } else {
--- End diff --
ok, done
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2363
@ravipesala CI pass, Please review it again.
---
[GitHub] carbondata issue #2363: [WIP][CARBONDATA-2591] SDK CarbonReader support filt...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2363
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5236/
---
[GitHub] carbondata issue #2363: [WIP][CARBONDATA-2591] SDK CarbonReader support filt...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5104/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5139/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5111/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5125/
---
[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...
Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r194323041
--- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java ---
@@ -179,7 +179,11 @@ public CarbonReaderBuilder setEndPoint(String value) {
if (isTransactionalTable) {
table = CarbonTable.buildFromTablePath(tableName, "default", tablePath);
} else {
- table = CarbonTable.buildDummyTable(tablePath);
+ if (filterExpression != null) {
+ table = CarbonTable.buildTable(tablePath, tableName, true);
+ } else {
--- End diff --
Add a comment about the changes and also can you make a separate method ?
If filterExpression is null, call CarbonTable.buildDummyTable(). else call CarbonTable.buildTable()
because buidTable will not tell whether it is a table with schema or without schema (dummy table).
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5131/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2363
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5245/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2363
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5239/
---
[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2363
retest this please
---
[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...
Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r194323660
--- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -105,6 +115,243 @@ public void testWriteAndReadFiles() throws IOException, InterruptedException {
FileUtils.deleteDirectory(new File(path));
}
+ @Test
+ public void testReadWithFilterOfTransactional() throws IOException, InterruptedException {
--- End diff --
All these code changes of this PR is for NonTransactional table. I think test case for Transactional table is redundant.
---