You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2022/08/30 05:58:56 UTC

[GitHub] [curator] mattisonchao opened a new pull request, #392: CURATOR-603 Use Awaitility to instead of Thread sleep method in recipes module.

mattisonchao opened a new pull request, #392:
URL: https://github.com/apache/curator/pull/392

   Use Awaitility to instead of Thread sleep method in recipes module.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] tisonkun commented on pull request #392: CURATOR-603 Use Awaitility to instead of Thread sleep method in recipes module.

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #392:
URL: https://github.com/apache/curator/pull/392#issuecomment-1306836692

   No activities. Closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] tisonkun closed pull request #392: CURATOR-603 Use Awaitility to instead of Thread sleep method in recipes module.

Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #392: CURATOR-603 Use Awaitility to instead of Thread sleep method in recipes module.
URL: https://github.com/apache/curator/pull/392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] tisonkun commented on pull request #392: CURATOR-603 Use Awaitility to instead of Thread sleep method in recipes module.

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #392:
URL: https://github.com/apache/curator/pull/392#issuecomment-1231180856

   @mattisonchao if you'd like to continue it, please merge master and ping me for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] tisonkun commented on pull request #392: CURATOR-603 Use Awaitility to instead of Thread sleep method in recipes module.

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #392:
URL: https://github.com/apache/curator/pull/392#issuecomment-1184013026

   I suggest you start a discussion on dev@curator.apache.org first. This is not a trivial improvement but which suite we'd prefer.
   
   I'll close this pull request before we reach a consensus.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] tisonkun closed pull request #392: CURATOR-603 Use Awaitility to instead of Thread sleep method in recipes module.

Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #392: CURATOR-603 Use Awaitility to instead of Thread sleep method in recipes module.
URL: https://github.com/apache/curator/pull/392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] mattisonchao commented on pull request #392: CURATOR-603 Use Awaitility to instead of Thread sleep method in recipes module.

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #392:
URL: https://github.com/apache/curator/pull/392#issuecomment-1184030397

   Sure, and thanks for your reply.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] tisonkun commented on pull request #392: CURATOR-603 Use Awaitility to instead of Thread sleep method in recipes module.

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #392:
URL: https://github.com/apache/curator/pull/392#issuecomment-1231180395

   @mattisonchao I just notice we already use awaitility in curator-client https://github.com/apache/curator/pull/389.
   
   Then I'm OK to continue the patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org