[GitHub] [couchdb-helm] willholley commented on pull request #80: Add CI via GitHub Actions

[GitBox <gi...@apache.org>]

willholley commented on PR #80:
URL: https://github.com/apache/couchdb-helm/pull/80#issuecomment-1158561300

   Thanks for the PR @colearendt - it generally looks good to me. On the discussion points:
   
   > how do we do this in such a way that it does not affect your current setup? Should we create a gh-pages branch to maintain the "new" index.yaml on until you want to cut over the definition of GitHub pages? Will that affect anything?
   
   I think this is right:
    * create a new `gh-pages` branch
    * merge this PR
    * backfill releases via #79 
    * update `.asf.yaml` to switch GH pages over to the new `gh-pages` branch
    * after switch over confirmed, remove `docs` from `main` branch
   
   > should we remove the "changed vs. all" components of the action? 
   If the change detection is reliable then I'm happy to go with linting changes only
   
   > are any of the dependencies concerning?
   They all look well used/maintained, so no concerns from me.
   
   > we also have an action that we use to code-generate README.md (to keep documentation up to date with the values.yaml file) via [helm-docs](https://github.com/norwoodj/helm-docs). Is this something that would be interesting to you?
   
   Yes - that sounds helpful!
   
   > are there any arguments to linting and testing that would be helpful? i.e. --upgrade maybe?
   I think testing with `--upgrade` makes sense as we do today. This has caught a few issues for us in the past.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org