You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ZENOTME (via GitHub)" <gi...@apache.org> on 2025/02/24 07:02:34 UTC

[I] Track: fix minimal version of dependencies [iceberg-rust]

ZENOTME opened a new issue, #1000:
URL: https://github.com/apache/iceberg-rust/issues/1000

   Context: https://github.com/apache/iceberg-rust/pull/987#discussion_r1967084652
   
   - [ ] tap
   - [ ] faststr
   - [ ] metainfo
   - [ ] linkedbytes
   
   After this issue resolve, we can remove the specific upgrade code in msrv: https://github.com/apache/iceberg-rust/blob/1a2a8c87732a0d61aad532b53466f259e3db9802/.github/workflows/ci.yml#L154


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Track: fix minimal version of dependencies [iceberg-rust]

Posted by "xxchan (via GitHub)" <gi...@apache.org>.
xxchan commented on issue #1000:
URL: https://github.com/apache/iceberg-rust/issues/1000#issuecomment-2798494303

   Regarding faststr/metainfo/linkedbytes, perhaps we can upgrade pilota/volo-thrift. But their latest versions are using edition2024, which requires 1.85 (We are currently 1.84).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Track: fix minimal version of dependencies [iceberg-rust]

Posted by "xxchan (via GitHub)" <gi...@apache.org>.
xxchan commented on issue #1000:
URL: https://github.com/apache/iceberg-rust/issues/1000#issuecomment-2798433292

   `bitvec` is only used by `iceberg::spec::values::Struct`, and its usage looks not very necessary. 
   What about
   ```rust
   pub struct Struct {
       /// Vector to store the field values
       fields: Vec<Literal>,
       /// Null bitmap
       null_bitmap: BitVec,
   }
   
   // change to
   
   pub struct Struct {
       /// Vector to store the field values
       fields: Vec<Option<Literal>>,
   }
   ```
   to remove `tap`/`bitvec`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Track: fix minimal version of dependencies [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #1000:
URL: https://github.com/apache/iceberg-rust/issues/1000#issuecomment-2803546003

   > I think we could close this issue for now? [#1209](https://github.com/apache/iceberg-rust/pull/1209) has added minimum deps in our `Cargo.toml`.
   
   Nice!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Track: fix minimal version of dependencies [iceberg-rust]

Posted by "xxchan (via GitHub)" <gi...@apache.org>.
xxchan commented on issue #1000:
URL: https://github.com/apache/iceberg-rust/issues/1000#issuecomment-2798421573

   > `tap` looks like an unmaintained crate. Who is relying on it? Can we have it removed?
   
   It's `bitvec`, which is also unmaintained.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Track: fix minimal version of dependencies [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #1000:
URL: https://github.com/apache/iceberg-rust/issues/1000#issuecomment-2677706211

   Most crates are maintained by @PureWhiteWu. I have contacted him and will find a way to get them fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Track: fix minimal version of dependencies [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #1000: Track: fix minimal version of dependencies
URL: https://github.com/apache/iceberg-rust/issues/1000


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Track: fix minimal version of dependencies [iceberg-rust]

Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on issue #1000:
URL: https://github.com/apache/iceberg-rust/issues/1000#issuecomment-2677716444

   > Most crates are maintained by [@PureWhiteWu](https://github.com/PureWhiteWu). I have contacted him and will find a way to get them fixed.
   
   Thanks @Xuanwo! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Track: fix minimal version of dependencies [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #1000:
URL: https://github.com/apache/iceberg-rust/issues/1000#issuecomment-2803534794

   Hi, hive_metastore 0.2 is now released which brings latest `pilota` and `volo-thrift`. But this version will need edition 2024 too, we will need to hold for a while.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Track: fix minimal version of dependencies [iceberg-rust]

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #1000:
URL: https://github.com/apache/iceberg-rust/issues/1000#issuecomment-2803540594

   I think we could close this issue for now? https://github.com/apache/iceberg-rust/pull/1209 has added minimum deps in our `Cargo.toml`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Track: fix minimal version of dependencies [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #1000:
URL: https://github.com/apache/iceberg-rust/issues/1000#issuecomment-2798450093

   > `bitvec` is only used by `iceberg::spec::values::Struct`, and its usage looks not very necessary. What about
   > 
   > pub struct Struct {
   >     /// Vector to store the field values
   >     fields: Vec<Literal>,
   >     /// Null bitmap
   >     null_bitmap: BitVec,
   > }
   > 
   > // change to
   > 
   > pub struct Struct {
   >     /// Vector to store the field values
   >     fields: Vec<Option<Literal>>,
   > }
   > to remove `tap`/`bitvec`?
   
   I suppport this idea. Using `BitVec` here is a bit over-optimized.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Track: fix minimal version of dependencies [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #1000:
URL: https://github.com/apache/iceberg-rust/issues/1000#issuecomment-2677691863

   `tap` looks like an unmaintained crate. Who is relying on it? Can we have it removed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org