You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2026/10/12 20:19:41 UTC
[Impala-ASF-CR] IMPALA-14839: Add counters for slowest channels in KrpcDataStreamSenders
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24104 )
Change subject: IMPALA-14839: Add counters for slowest channels in KrpcDataStreamSenders
......................................................................
Patch Set 3:
> Patch Set 3:
>
> > This seems useful. Could use a test.
>
> "Could use a test."
> I am unsure about the usefulness of adding tests for this kind of diagnostic features, the test will be much more complex than the change itself. I guess this would need new kind of debug actions to only introduce delay is specific host in a query to ensure that there is a "slowest" network / receiver. Maybe move this to another ticket? Such debug actions could be useful for other things too.
Ack. It's fine as-is.
--
To view, visit http://gerrit.cloudera.org:8080/24104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e56dab3603ea6c5fb345793485af6ed52613046
Gerrit-Change-Number: 24104
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Oct 2026 20:19:41 +0000
Gerrit-HasComments: No