You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/06 17:22:34 UTC
[GitHub] john-bodley commented on a change in pull request #5830: Get 'Test
Connection' button to take 'engine_params' into account
john-bodley commented on a change in pull request #5830: Get 'Test Connection' button to take 'engine_params' into account
URL: https://github.com/apache/incubator-superset/pull/5830#discussion_r215709798
##########
File path: superset/views/core.py
##########
@@ -1701,16 +1701,16 @@ def testconn(self):
username),
)
- connect_args = (
+ engine_params = (
request.json
.get('extras', {})
- .get('engine_params', {})
- .get('connect_args', {}))
+ .get('engine_params', {}))
+ connect_args = engine_params.get('connect_args')
Review comment:
Isn't `connect_args` now unused?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org