You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/03/29 13:36:13 UTC

[GitHub] [ozone] adoroszlai opened a new pull request, #4495: HDDS-8276. EC file checksum calculation fails with topology-aware read enabled

adoroszlai opened a new pull request, #4495:
URL: https://github.com/apache/ozone/pull/4495

   ## What changes were proposed in this pull request?
   
   `ECFileChecksumHelper#getChunkInfos` copies the original EC pipeline and limits nodes to specific replicas.  However, the list of "nodes in order", used for topology-aware read, still contains all original nodes.  Thus it may happen that read is attempted from the wrong node.
   
   This patch updates "nodes in order" in the copy to reflect the same set of nodes as the unordered one.
   
   https://issues.apache.org/jira/browse/HDDS-8276
   
   ## How was this patch tested?
   
   Updated the integration test `TestOzoneFileChecksum` to cover both topology-aware and regular read.
   
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/4553955626


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #4495: HDDS-8276. EC file checksum calculation fails with topology-aware read enabled

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4495:
URL: https://github.com/apache/ozone/pull/4495#issuecomment-1489261235

   Thanks @sodonnel for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai merged pull request #4495: HDDS-8276. EC file checksum calculation fails with topology-aware read enabled

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4495:
URL: https://github.com/apache/ozone/pull/4495


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org