[jira] [Comment Edited] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

["Nazerke Seidan (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551500#comment-17551500 ] 

Nazerke Seidan edited comment on SOLR-14699 at 6/8/22 9:25 AM:
---------------------------------------------------------------

Not sure if [~janhoy] , you meant a possible concern of extracting MDC. If it is about extracting MDC values, Log4j provides context data read-only map for MDC. 


was (Author: nazerke):
if the concern is about extracting MDC values, Log4j provides context data read-only map for MDC values. 

> Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-14699
>                 URL: https://issues.apache.org/jira/browse/SOLR-14699
>             Project: Solr
>          Issue Type: Improvement
>          Components: logging
>            Reporter: David Smiley
>            Priority: Minor
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {{SolrQueryResponse.getToLogAsString}} encodes the NamedList into a String with simple space-separated pairs with name=value.  However, it does no escaping/encoding, and as-such a value might itself contain spaces and equals.  This is a problem if these logs are being parsed, and we'd like to ensure we do so correctly.  Note that SolrLogPostTool (aka "postlogs") parses these logs.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org