You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/15 16:21:21 UTC
[GitHub] [spark] yaooqinn opened a new pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
yaooqinn opened a new pull request #28835:
URL: https://github.com/apache/spark/pull/28835
### What changes were proposed in this pull request?
fix flaky test
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644918559
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644237920
**[Test build #124064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124064/testReport)** for PR 28835 at commit [`f9ea941`](https://github.com/apache/spark/commit/f9ea941c04d27f0ec6fc97292b43f0168271dc2a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645106412
**[Test build #124150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124150/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644944016
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645916119
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644259220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645184484
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645193265
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645914919
**[Test build #124202 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124202/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645106412
**[Test build #124150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124150/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28835:
URL: https://github.com/apache/spark/pull/28835
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646447496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645184495
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124158/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644559477
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645193273
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124150/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644450563
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644234589
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644259220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644257906
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646027700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644485307
Sorry, @yaooqinn and @cloud-fan . It seems that we had better revert the patch first because it's too flaky.
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645826021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646447496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646402299
**[Test build #124250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124250/testReport)** for PR 28835 at commit [`e409f9a`](https://github.com/apache/spark/commit/e409f9ac1dd899e1d81f1e45000e4799ce3e3a2c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644574855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644256162
**[Test build #124068 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124068/testReport)** for PR 28835 at commit [`7908d62`](https://github.com/apache/spark/commit/7908d628654c32dee2f3e15435c378935c1d06eb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645184121
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645181025
**[Test build #124157 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124157/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] juliuszsompolski commented on a change in pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
juliuszsompolski commented on a change in pull request #28835:
URL: https://github.com/apache/spark/pull/28835#discussion_r442250684
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala
##########
@@ -114,10 +134,31 @@ private[thriftserver] trait ReflectedCompositeService { this: AbstractService =>
invoke(classOf[AbstractService], this, "ensureCurrentState", classOf[STATE] -> STATE.NOTINITED)
setAncestorField(this, 3, "hiveConf", hiveConf)
invoke(classOf[AbstractService], this, "changeState", classOf[STATE] -> STATE.INITED)
- if (HiveUtils.isHive23) {
- getAncestorField[Logger](this, 3, "LOG").info(s"Service: $getName is inited.")
- } else {
- getAncestorField[Log](this, 3, "LOG").info(s"Service: $getName is inited.")
+ logInfo(s"Service: $getName is inited.")
+ }
+
+ def startCompositeService(): Unit = {
+ // Emulating `CompositeService.start`
+ val serviceList = getAncestorField[JList[Service]](this, 2, "serviceList")
+ var serviceStartCount = 0
+ try {
+ serviceList.asScala.foreach { service =>
+ service.start()
+ serviceStartCount += 1
+ }
+ } catch {
+ case NonFatal(e) =>
+ logError(s"Error starting services $getName", e)
+ invoke(classOf[CompositeService], this, "stop",
+ classOf[Int] -> new Integer(serviceStartCount))
+ throw new ServiceException("Failed to Start " + getName, e)
}
+
+ // Emulating `AbstractService.start`
+ val startTime = new java.lang.Long(System.currentTimeMillis())
+ setAncestorField(this, 3, "startTime", startTime)
+ invoke(classOf[AbstractService], this, "ensureCurrentState", classOf[STATE] -> STATE.INITED)
Review comment:
This can throw IllegalStateException, and in the original implementation it is inside the try catch block, which would turn it into ServiceException.
Let's do that as well just in case :-).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645181821
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644577485
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644566919
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645260247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644237920
**[Test build #124064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124064/testReport)** for PR 28835 at commit [`f9ea941`](https://github.com/apache/spark/commit/f9ea941c04d27f0ec6fc97292b43f0168271dc2a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644249420
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645180015
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644566272
**[Test build #124102 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124102/testReport)** for PR 28835 at commit [`9c6ac83`](https://github.com/apache/spark/commit/9c6ac83afbe26f1277a72c04ac3b1ec40a8c7141).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644514283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644574884
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644919051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645181821
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645181473
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644268757
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644559034
**[Test build #124088 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124088/testReport)** for PR 28835 at commit [`9c6ac83`](https://github.com/apache/spark/commit/9c6ac83afbe26f1277a72c04ac3b1ec40a8c7141).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646291225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646059460
**[Test build #124218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124218/testReport)** for PR 28835 at commit [`e409f9a`](https://github.com/apache/spark/commit/e409f9ac1dd899e1d81f1e45000e4799ce3e3a2c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644625214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645825372
**[Test build #124202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124202/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646026446
**[Test build #124215 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124215/testReport)** for PR 28835 at commit [`d5341ea`](https://github.com/apache/spark/commit/d5341ea8b3d46c44b35c4a0eb293da4cda40bcc3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644260135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645826021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645825372
**[Test build #124202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124202/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646402299
**[Test build #124250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124250/testReport)** for PR 28835 at commit [`e409f9a`](https://github.com/apache/spark/commit/e409f9ac1dd899e1d81f1e45000e4799ce3e3a2c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645184484
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646475040
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124250/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646475025
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644273985
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646199933
**[Test build #124228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124228/testReport)** for PR 28835 at commit [`e409f9a`](https://github.com/apache/spark/commit/e409f9ac1dd899e1d81f1e45000e4799ce3e3a2c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644259675
**[Test build #124069 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124069/testReport)** for PR 28835 at commit [`7908d62`](https://github.com/apache/spark/commit/7908d628654c32dee2f3e15435c378935c1d06eb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644827985
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124108/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645260247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644516069
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645940901
**[Test build #124215 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124215/testReport)** for PR 28835 at commit [`d5341ea`](https://github.com/apache/spark/commit/d5341ea8b3d46c44b35c4a0eb293da4cda40bcc3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646061499
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124218/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644559477
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645260824
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124162/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645941396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645183646
**[Test build #124158 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124158/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644580084
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644892653
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644256667
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646061426
**[Test build #124218 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124218/testReport)** for PR 28835 at commit [`e409f9a`](https://github.com/apache/spark/commit/e409f9ac1dd899e1d81f1e45000e4799ce3e3a2c).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645941396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646059460
**[Test build #124218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124218/testReport)** for PR 28835 at commit [`e409f9a`](https://github.com/apache/spark/commit/e409f9ac1dd899e1d81f1e45000e4799ce3e3a2c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644917833
**[Test build #124135 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124135/testReport)** for PR 28835 at commit [`9cdd7fa`](https://github.com/apache/spark/commit/9cdd7fac27148308a78bd59d39954b8f86984493).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645184470
**[Test build #124158 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124158/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645260791
**[Test build #124162 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124162/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644248826
**[Test build #124067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124067/testReport)** for PR 28835 at commit [`03fcf59`](https://github.com/apache/spark/commit/03fcf59197e625cdba3ef746d0d707e953990705).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644826816
**[Test build #124108 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124108/testReport)** for PR 28835 at commit [`9c6ac83`](https://github.com/apache/spark/commit/9c6ac83afbe26f1277a72c04ac3b1ec40a8c7141).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645916119
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646027700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644917833
**[Test build #124135 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124135/testReport)** for PR 28835 at commit [`9cdd7fa`](https://github.com/apache/spark/commit/9cdd7fac27148308a78bd59d39954b8f86984493).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644450238
**[Test build #124069 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124069/testReport)** for PR 28835 at commit [`7908d62`](https://github.com/apache/spark/commit/7908d628654c32dee2f3e15435c378935c1d06eb).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644919035
**[Test build #124135 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124135/testReport)** for PR 28835 at commit [`9cdd7fa`](https://github.com/apache/spark/commit/9cdd7fac27148308a78bd59d39954b8f86984493).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644564303
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644268766
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124067/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644259675
**[Test build #124069 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124069/testReport)** for PR 28835 at commit [`7908d62`](https://github.com/apache/spark/commit/7908d628654c32dee2f3e15435c378935c1d06eb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644256162
**[Test build #124068 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124068/testReport)** for PR 28835 at commit [`7908d62`](https://github.com/apache/spark/commit/7908d628654c32dee2f3e15435c378935c1d06eb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646400317
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645181826
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124157/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644944020
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124119/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645181804
**[Test build #124157 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124157/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644249420
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644827975
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646400756
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645184121
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646474813
**[Test build #124250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124250/testReport)** for PR 28835 at commit [`e409f9a`](https://github.com/apache/spark/commit/e409f9ac1dd899e1d81f1e45000e4799ce3e3a2c).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644490708
Thanks, @dongjoon-hyun, and sorry for the inconvenience. I will keep working on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644514044
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644919058
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124135/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644273778
**[Test build #124068 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124068/testReport)** for PR 28835 at commit [`7908d62`](https://github.com/apache/spark/commit/7908d628654c32dee2f3e15435c378935c1d06eb).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644574994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124087/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646402637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645106680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646402637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646201131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646400501
**[Test build #124249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124249/testReport)** for PR 28835 at commit [`e409f9a`](https://github.com/apache/spark/commit/e409f9ac1dd899e1d81f1e45000e4799ce3e3a2c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646201131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644268510
**[Test build #124067 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124067/testReport)** for PR 28835 at commit [`03fcf59`](https://github.com/apache/spark/commit/03fcf59197e625cdba3ef746d0d707e953990705).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644235466
Thank you for investigating this, @yaooqinn .
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644892667
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124113/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644673755
**[Test build #124119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124119/testReport)** for PR 28835 at commit [`9cdd7fa`](https://github.com/apache/spark/commit/9cdd7fac27148308a78bd59d39954b8f86984493).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644514845
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645106680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644273985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644514283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28835:
URL: https://github.com/apache/spark/pull/28835#discussion_r442266463
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala
##########
@@ -114,10 +134,31 @@ private[thriftserver] trait ReflectedCompositeService { this: AbstractService =>
invoke(classOf[AbstractService], this, "ensureCurrentState", classOf[STATE] -> STATE.NOTINITED)
setAncestorField(this, 3, "hiveConf", hiveConf)
invoke(classOf[AbstractService], this, "changeState", classOf[STATE] -> STATE.INITED)
- if (HiveUtils.isHive23) {
- getAncestorField[Logger](this, 3, "LOG").info(s"Service: $getName is inited.")
- } else {
- getAncestorField[Log](this, 3, "LOG").info(s"Service: $getName is inited.")
+ logInfo(s"Service: $getName is inited.")
+ }
+
+ def startCompositeService(): Unit = {
+ // Emulating `CompositeService.start`
+ val serviceList = getAncestorField[JList[Service]](this, 2, "serviceList")
+ var serviceStartCount = 0
+ try {
+ serviceList.asScala.foreach { service =>
+ service.start()
+ serviceStartCount += 1
+ }
+ } catch {
+ case NonFatal(e) =>
+ logError(s"Error starting services $getName", e)
+ invoke(classOf[CompositeService], this, "stop",
+ classOf[Int] -> new Integer(serviceStartCount))
+ throw new ServiceException("Failed to Start " + getName, e)
}
+
+ // Emulating `AbstractService.start`
+ val startTime = new java.lang.Long(System.currentTimeMillis())
+ setAncestorField(this, 3, "startTime", startTime)
+ invoke(classOf[AbstractService], this, "ensureCurrentState", classOf[STATE] -> STATE.INITED)
Review comment:
Ah, I see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644234589
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644918559
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644566919
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646199933
**[Test build #124228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124228/testReport)** for PR 28835 at commit [`e409f9a`](https://github.com/apache/spark/commit/e409f9ac1dd899e1d81f1e45000e4799ce3e3a2c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28835:
URL: https://github.com/apache/spark/pull/28835#discussion_r440743061
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala
##########
@@ -94,6 +95,12 @@ private[hive] class SparkSQLCLIService(hiveServer: HiveServer2, sqlContext: SQLC
initCompositeService(hiveConf)
}
+ /**
+ * the super class [[CLIService#start]] starts a useless dummy metastore client, skip it and call
+ * the ancestor [[CompositeService#start]] directly.
+ */
+ override def start(): Unit = startCompositeService()
Review comment:
CLIService will create a metastore connection during start, which is useless for our dummy execution hive conf and will cause class cast issue though different classloader
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645259592
**[Test build #124162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124162/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646451325
thanks, merging to master! (don't backport as it's not a test only PR anymore)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646061471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646475025
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645181025
**[Test build #124157 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124157/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645193265
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645770966
cc @juliuszsompolski
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644268757
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644579388
**[Test build #124108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124108/testReport)** for PR 28835 at commit [`9c6ac83`](https://github.com/apache/spark/commit/9c6ac83afbe26f1277a72c04ac3b1ec40a8c7141).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645940901
**[Test build #124215 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124215/testReport)** for PR 28835 at commit [`d5341ea`](https://github.com/apache/spark/commit/d5341ea8b3d46c44b35c4a0eb293da4cda40bcc3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644674346
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28835:
URL: https://github.com/apache/spark/pull/28835#discussion_r440743596
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala
##########
@@ -94,6 +95,12 @@ private[hive] class SparkSQLCLIService(hiveServer: HiveServer2, sqlContext: SQLC
initCompositeService(hiveConf)
}
+ /**
+ * the super class [[CLIService#start]] starts a useless dummy metastore client, skip it and call
+ * the ancestor [[CompositeService#start]] directly.
+ */
+ override def start(): Unit = startCompositeService()
Review comment:
Here we bypass it and start the registered services as CompositeService does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645183646
**[Test build #124158 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124158/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644574884
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644260135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644674346
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644514044
**[Test build #124087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124087/testReport)** for PR 28835 at commit [`9c6ac83`](https://github.com/apache/spark/commit/9c6ac83afbe26f1277a72c04ac3b1ec40a8c7141).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646446486
**[Test build #124249 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124249/testReport)** for PR 28835 at commit [`e409f9a`](https://github.com/apache/spark/commit/e409f9ac1dd899e1d81f1e45000e4799ce3e3a2c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644450563
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646400756
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645259592
**[Test build #124162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124162/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645192942
**[Test build #124150 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124150/testReport)** for PR 28835 at commit [`5ce343a`](https://github.com/apache/spark/commit/5ce343aef6e17eaedb258f19f21823015e8066ce).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645260812
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644256667
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645181473
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644515779
**[Test build #124088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124088/testReport)** for PR 28835 at commit [`9c6ac83`](https://github.com/apache/spark/commit/9c6ac83afbe26f1277a72c04ac3b1ec40a8c7141).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644559483
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124088/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646060359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] juliuszsompolski commented on a change in pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
juliuszsompolski commented on a change in pull request #28835:
URL: https://github.com/apache/spark/pull/28835#discussion_r442106655
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala
##########
@@ -114,10 +134,29 @@ private[thriftserver] trait ReflectedCompositeService { this: AbstractService =>
invoke(classOf[AbstractService], this, "ensureCurrentState", classOf[STATE] -> STATE.NOTINITED)
setAncestorField(this, 3, "hiveConf", hiveConf)
invoke(classOf[AbstractService], this, "changeState", classOf[STATE] -> STATE.INITED)
- if (HiveUtils.isHive23) {
- getAncestorField[Logger](this, 3, "LOG").info(s"Service: $getName is inited.")
- } else {
- getAncestorField[Log](this, 3, "LOG").info(s"Service: $getName is inited.")
+ logInfo(s"Service: $getName is inited.")
+ }
+
+ def startCompositeService(): Unit = {
+ // Emulating `CompositeService.init(hiveConf)`
+ val serviceList = getAncestorField[JList[Service]](this, 2, "serviceList")
+ var serviceStartCount = 0
+ try {
+ serviceList.asScala.foreach { service =>
+ service.start()
+ serviceStartCount += 1
+ }
+ } catch {
+ case NonFatal(e) =>
+ logError(s"Error starting services $getName", e)
+ invoke(classOf[CompositeService], this, "stop",
+ classOf[Int] -> new Integer(serviceStartCount))
+ throw new ServiceException("Failed to Start " + getName, e)
}
+
+ // Emulating `AbstractService.start`
Review comment:
AbstractService.start does also `startTime = System.currentTimeMillis();`
Lets set startTime as well, just in case.
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SharedThriftServer.scala
##########
@@ -69,23 +89,42 @@ trait SharedThriftServer extends SharedSparkSession {
}
private def startThriftServer(attempt: Int): Unit = {
- logInfo(s"Trying to start HiveThriftServer2:, attempt=$attempt")
+ logInfo(s"Trying to start HiveThriftServer2: mode=$mode, attempt=$attempt")
val sqlContext = spark.newSession().sqlContext
- // Set the HIVE_SERVER2_THRIFT_PORT to 0, so it could randomly pick any free port to use.
+ sqlContext.setConf(ConfVars.METASTORECONNECTURLKEY.varname,
+ s"jdbc:derby:;databaseName=$metastorePath;create=true")
+ sqlContext.setConf(ConfVars.METASTOREURIS.varname, "")
Review comment:
What's this for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644892653
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644624396
**[Test build #124113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124113/testReport)** for PR 28835 at commit [`5e79ad9`](https://github.com/apache/spark/commit/5e79ad98264a263b5d6d9829dc81258f3eff1497).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644919051
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645257874
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644827975
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644273994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124068/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645260812
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644579388
**[Test build #124108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124108/testReport)** for PR 28835 at commit [`9c6ac83`](https://github.com/apache/spark/commit/9c6ac83afbe26f1277a72c04ac3b1ec40a8c7141).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28835:
URL: https://github.com/apache/spark/pull/28835#discussion_r442110126
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala
##########
@@ -114,10 +134,29 @@ private[thriftserver] trait ReflectedCompositeService { this: AbstractService =>
invoke(classOf[AbstractService], this, "ensureCurrentState", classOf[STATE] -> STATE.NOTINITED)
setAncestorField(this, 3, "hiveConf", hiveConf)
invoke(classOf[AbstractService], this, "changeState", classOf[STATE] -> STATE.INITED)
- if (HiveUtils.isHive23) {
- getAncestorField[Logger](this, 3, "LOG").info(s"Service: $getName is inited.")
- } else {
- getAncestorField[Log](this, 3, "LOG").info(s"Service: $getName is inited.")
+ logInfo(s"Service: $getName is inited.")
+ }
+
+ def startCompositeService(): Unit = {
+ // Emulating `CompositeService.init(hiveConf)`
+ val serviceList = getAncestorField[JList[Service]](this, 2, "serviceList")
+ var serviceStartCount = 0
+ try {
+ serviceList.asScala.foreach { service =>
+ service.start()
+ serviceStartCount += 1
+ }
+ } catch {
+ case NonFatal(e) =>
+ logError(s"Error starting services $getName", e)
+ invoke(classOf[CompositeService], this, "stop",
+ classOf[Int] -> new Integer(serviceStartCount))
+ throw new ServiceException("Failed to Start " + getName, e)
}
+
+ // Emulating `AbstractService.start`
Review comment:
Nice catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645104925
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644625214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644580084
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646400501
**[Test build #124249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124249/testReport)** for PR 28835 at commit [`e409f9a`](https://github.com/apache/spark/commit/e409f9ac1dd899e1d81f1e45000e4799ce3e3a2c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646291225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645824046
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644515779
**[Test build #124088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124088/testReport)** for PR 28835 at commit [`9c6ac83`](https://github.com/apache/spark/commit/9c6ac83afbe26f1277a72c04ac3b1ec40a8c7141).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644516069
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644450568
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124069/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP]Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-645181449
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644248826
**[Test build #124067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124067/testReport)** for PR 28835 at commit [`03fcf59`](https://github.com/apache/spark/commit/03fcf59197e625cdba3ef746d0d707e953990705).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644258791
**[Test build #124064 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124064/testReport)** for PR 28835 at commit [`f9ea941`](https://github.com/apache/spark/commit/f9ea941c04d27f0ec6fc97292b43f0168271dc2a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644944016
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646290147
**[Test build #124228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124228/testReport)** for PR 28835 at commit [`e409f9a`](https://github.com/apache/spark/commit/e409f9ac1dd899e1d81f1e45000e4799ce3e3a2c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646198981
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646400808
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-646060359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28835:
URL: https://github.com/apache/spark/pull/28835#discussion_r442111594
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SharedThriftServer.scala
##########
@@ -69,23 +89,42 @@ trait SharedThriftServer extends SharedSparkSession {
}
private def startThriftServer(attempt: Int): Unit = {
- logInfo(s"Trying to start HiveThriftServer2:, attempt=$attempt")
+ logInfo(s"Trying to start HiveThriftServer2: mode=$mode, attempt=$attempt")
val sqlContext = spark.newSession().sqlContext
- // Set the HIVE_SERVER2_THRIFT_PORT to 0, so it could randomly pick any free port to use.
+ sqlContext.setConf(ConfVars.METASTORECONNECTURLKEY.varname,
+ s"jdbc:derby:;databaseName=$metastorePath;create=true")
+ sqlContext.setConf(ConfVars.METASTOREURIS.varname, "")
Review comment:
Some test failures showed that the metastore client was trying to connect through `METASTOREURIS` which seems to be set by other tests. But now I guess this won't be necessary as we skip that part
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28835:
URL: https://github.com/apache/spark/pull/28835#issuecomment-644916287
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org