You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "bigDouble46 (via GitHub)" <gi...@apache.org> on 2023/12/05 16:04:51 UTC
[PR] Remove unused rxnetty dependency [servicecomb-java-chassis]
bigDouble46 opened a new pull request, #4094:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4094
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused rxnetty dependency [servicecomb-java-chassis]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj merged PR #4094:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused rxnetty dependency [servicecomb-java-chassis]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4094:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4094#issuecomment-1841804187
## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4094?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`ce3d69e`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/ce3d69e7c3020953845c0eb909b51d5445f5d733?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 44.56% compared to head [(`5707ad2`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4094?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 44.64%.
> :exclamation: Current head 5707ad2 differs from pull request most recent head 35904e3. Consider uploading reports for the commit 35904e3 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4094 +/- ##
============================================
+ Coverage 44.56% 44.64% +0.07%
- Complexity 5371 5379 +8
============================================
Files 1379 1379
Lines 34043 34043
Branches 3297 3297
============================================
+ Hits 15170 15197 +27
+ Misses 17649 17621 -28
- Partials 1224 1225 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4094?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org