You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "wusamzong (via GitHub)" <gi...@apache.org> on 2023/01/30 13:41:06 UTC

[GitHub] [yunikorn-site] wusamzong opened a new pull request, #258: [YUNIKORN-1516] Adding Chinese translation of System Rest API

wusamzong opened a new pull request, #258:
URL: https://github.com/apache/yunikorn-site/pull/258

   ### What is this PR for?
   I translate the page `System` to Chinese
   
   ### What type of PR is it?
   * [x] - Task
   
   ### What is the Jira issue?
   * Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-1516/
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-site] 0yukali0 commented on a diff in pull request #258: [YUNIKORN-1516] Adding Chinese translation of System Rest API

Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 commented on code in PR #258:
URL: https://github.com/apache/yunikorn-site/pull/258#discussion_r1093180835


##########
i18n/zh-cn/docusaurus-plugin-content-docs/current/api/system.md:
##########
@@ -0,0 +1,225 @@
+---
+id: system
+title: 系統
+---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+这是一个给 分析工具─[pprof](https://github.com/google/pprof) 的端点。

Review Comment:
   是一个给分析工具─[pprof](https://github.com/google/pprof)的端点。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-site] 0yukali0 commented on a diff in pull request #258: [YUNIKORN-1516] Adding Chinese translation of System Rest API

Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 commented on code in PR #258:
URL: https://github.com/apache/yunikorn-site/pull/258#discussion_r1094099600


##########
i18n/zh-cn/docusaurus-plugin-content-docs/current/api/system.md:
##########
@@ -0,0 +1,225 @@
+---
+id: system
+title: 系統
+---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+这是一个给 分析工具─[pprof](https://github.com/google/pprof) 的端点。

Review Comment:
   Update:
   This would be better, I think.
   这些端点是用于提供資訊給pprof分析工具。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-site] wusamzong commented on a diff in pull request #258: [YUNIKORN-1516] Adding Chinese translation of System Rest API

Posted by "wusamzong (via GitHub)" <gi...@apache.org>.
wusamzong commented on code in PR #258:
URL: https://github.com/apache/yunikorn-site/pull/258#discussion_r1094308475


##########
i18n/zh-cn/docusaurus-plugin-content-docs/current/api/system.md:
##########
@@ -0,0 +1,225 @@
+---
+id: system
+title: 系統
+---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+这是一个给 分析工具─[pprof](https://github.com/google/pprof) 的端点。

Review Comment:
   Thanks for your review, I've updated the changes to the new commit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-site] 0yukali0 merged pull request #258: [YUNIKORN-1516] Adding Chinese translation of System Rest API

Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 merged PR #258:
URL: https://github.com/apache/yunikorn-site/pull/258


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org