You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/07 22:09:00 UTC

[GitHub] [airflow] danccooper commented on pull request #10230: Fix KubernetesPodOperator reattachment

danccooper commented on pull request #10230:
URL: https://github.com/apache/airflow/pull/10230#issuecomment-670737449


   LGTM, logic is much clearer, thank you.
   
   One thing to consider is the comment by @dakov here: https://github.com/apache/airflow/pull/6377#discussion_r459648834
   
   Perhaps on line 280 where we check for 0 or 1 existing pod & raise otherwise, we should only raise if `reattach_on_restart` is True? As if it is False then we probably don't care & we will create another pod anyway.  What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org