You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/28 04:02:07 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request, #19624: Replace Programs.standard() with RBO and CBO optimize logic

strongduanmu opened a new pull request, #19624:
URL: https://github.com/apache/shardingsphere/pull/19624

   Ref #19580.
   
   Changes proposed in this pull request:
   - replace Programs.standard() with RBO and CBO optimize logic
   - add hepPlanners in OptimizerPlannerContext
   - update ShardingSphereOptimizer unit test
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #19624: Replace Programs.standard() with RBO and CBO optimize logic

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19624:
URL: https://github.com/apache/shardingsphere/pull/19624#issuecomment-1197676403

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19624?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19624](https://codecov.io/gh/apache/shardingsphere/pull/19624?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3af8817) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7d4e2ce860fafbb8df0bc9e576476b79e5818d10?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d4e2ce) will **increase** coverage by `0.05%`.
   > The diff coverage is `83.92%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #19624      +/-   ##
   ============================================
   + Coverage     60.17%   60.23%   +0.05%     
     Complexity     2397     2397              
   ============================================
     Files          3840     3840              
     Lines         54653    54709      +56     
     Branches       7637     7645       +8     
   ============================================
   + Hits          32888    32952      +64     
   + Misses        18940    18925      -15     
   - Partials       2825     2832       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19624?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/scenario/rulealtered/RuleAlteredJobPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/19624/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL3J1bGVhbHRlcmVkL1J1bGVBbHRlcmVkSm9iUHJlcGFyZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...proxy/backend/config/ProxyConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/19624/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb25maWcvUHJveHlDb25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `61.70% <30.76%> (-11.83%)` | :arrow_down: |
   | [.../federation/optimizer/ShardingSphereOptimizer.java](https://codecov.io/gh/apache/shardingsphere/pull/19624/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLW9wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvZmVkZXJhdGlvbi9vcHRpbWl6ZXIvU2hhcmRpbmdTcGhlcmVPcHRpbWl6ZXIuamF2YQ==) | `83.33% <100.00%> (+5.55%)` | :arrow_up: |
   | [...ontext/planner/OptimizerPlannerContextFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/19624/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLW9wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvZmVkZXJhdGlvbi9vcHRpbWl6ZXIvY29udGV4dC9wbGFubmVyL09wdGltaXplclBsYW5uZXJDb250ZXh0RmFjdG9yeS5qYXZh) | `100.00% <100.00%> (ø)` | |
   | [...optimizer/planner/QueryOptimizePlannerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/19624/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLW9wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvZmVkZXJhdGlvbi9vcHRpbWl6ZXIvcGxhbm5lci9RdWVyeU9wdGltaXplUGxhbm5lckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [.../postgresql/command/query/extended/JDBCPortal.java](https://codecov.io/gh/apache/shardingsphere/pull/19624/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9jb21tYW5kL3F1ZXJ5L2V4dGVuZGVkL0pEQkNQb3J0YWwuamF2YQ==) | `89.61% <100.00%> (+21.18%)` | :arrow_up: |
   | [...source/pool/destroyer/DataSourcePoolDestroyer.java](https://codecov.io/gh/apache/shardingsphere/pull/19624/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Bvb2wvZGVzdHJveWVyL0RhdGFTb3VyY2VQb29sRGVzdHJveWVyLmphdmE=) | `66.66% <0.00%> (-16.67%)` | :arrow_down: |
   | [...atasource/props/DataSourcePropertiesValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/19624/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Byb3BzL0RhdGFTb3VyY2VQcm9wZXJ0aWVzVmFsaWRhdG9yLmphdmE=) | `88.00% <0.00%> (-7.66%)` | :arrow_down: |
   | [...istsql/rdl/resource/AddResourceBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/19624/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL3Jlc291cmNlL0FkZFJlc291cmNlQmFja2VuZEhhbmRsZXIuamF2YQ==) | `83.33% <0.00%> (+0.72%)` | :arrow_up: |
   | ... and [4 more](https://codecov.io/gh/apache/shardingsphere/pull/19624/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tuichenchuxin merged pull request #19624: Replace Programs.standard() with RBO and CBO optimize logic

Posted by GitBox <gi...@apache.org>.
tuichenchuxin merged PR #19624:
URL: https://github.com/apache/shardingsphere/pull/19624


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org