[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #148: Add signing for release artifacts

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #148:
URL: https://github.com/apache/incubator-pekko-grpc/pull/148#discussion_r1286791961


##########
gradle-plugin/build.gradle:
##########
@@ -81,6 +82,16 @@ nexusPublishing {
     }
 }
 
+Boolean isReleaseVersion = !version.toString().endsWith("SNAPSHOT")
+
+signing {
+    setRequired({
+        isReleaseVersion && gradle.taskGraph.hasTask("publish")
+    })
+    useGpgCmd()

Review Comment:
   Gradle will use JVM signing, `useGpgCmd()` is set because people such as myself have their signing key stored on a key device (i.e. YubiKey) which doesn't work with JVM signing.
   
   Its also consistent with sbt-gpg (which also uses gpg).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org