You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/04 13:12:10 UTC

[GitHub] [skywalking] jiang1997 opened a new pull request, #9303: Add component ID and logo for Python Bottle plugin

jiang1997 opened a new pull request, #9303:
URL: https://github.com/apache/skywalking/pull/9303

   Add Bottle logo
   
   <!--
       ⚠️ Please make sure to read this template first, pull requests that don't accord with this template
       maybe closed without notice.
       Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
       Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
   -->
   
   <!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
   ### Fix <bug description or the bug issue number or bug issue link>
   - [ ] Add a unit test to verify that the fix works.
   - [ ] Explain briefly why the bug exists and how to fix it.
        ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
   
   <!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
   ### Improve the performance of <class or module or ...>
   - [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
   - [ ] The benchmark result.
   ```text
   <Paste the benchmark results here>
   ```
   - [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
        ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
   
   <!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
   ### <Feature description>
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [ ] Update the documentation to include this new feature.
   - [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [ ] If it's UI related, attach the screenshots below.
        ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
   
   - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] jiang1997 commented on pull request #9303: Add component ID and logo for Python Bottle plugin

Posted by GitBox <gi...@apache.org>.

jiang1997 commented on PR #9303:
URL: https://github.com/apache/skywalking/pull/9303#issuecomment-1173823508

   > Why is `skywalking-ui` submodule updated?
   
   I thought the image files were going there. Isn’t it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] jiang1997 closed pull request #9303: Add component ID and logo for Python Bottle plugin

Posted by GitBox <gi...@apache.org>.

jiang1997 closed pull request #9303: Add component ID and logo for Python Bottle plugin
URL: https://github.com/apache/skywalking/pull/9303


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #9303: Add component ID and logo for Python Bottle plugin

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on PR #9303:
URL: https://github.com/apache/skywalking/pull/9303#issuecomment-1173840820

   Please keep the submodule unchanged. No matter if this repo includes the latest commit ID of the UI repo, you don't change it, so, it is irrelevant. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] jiang1997 commented on pull request #9303: Add component ID and logo for Python Bottle plugin

Posted by GitBox <gi...@apache.org>.

jiang1997 commented on PR #9303:
URL: https://github.com/apache/skywalking/pull/9303#issuecomment-1173843362

   > Please keep the submodule unchanged. No matter if this repo includes the latest commit ID of the UI repo, you don't change it, so, it is irrelevant.
   
   Right.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #9303: Add component ID and logo for Python Bottle plugin

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on PR #9303:
URL: https://github.com/apache/skywalking/pull/9303#issuecomment-1173825678

   > > Why is `skywalking-ui` submodule updated?
   > 
   > I thought the image files were going there. Isn’t it?
   
   What image? I don't see any logo relative PR in that repository.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] jiang1997 commented on pull request #9303: Add component ID and logo for Python Bottle plugin

Posted by GitBox <gi...@apache.org>.

jiang1997 commented on PR #9303:
URL: https://github.com/apache/skywalking/pull/9303#issuecomment-1173839175

   > > > Why is `skywalking-ui` submodule updated?
   > > 
   > > 
   > > I thought the image files were going there. Isn’t it?
   > 
   > What image? I don't see any logo relative PR in that repository.
   
   The plugin logo.
   Yes, I did not create any PR for that repo.
   I just refer to this https://stackoverflow.com/a/47971286/9845190 to create one pull request across submodules.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #9303: Add component ID and logo for Python Bottle plugin

Posted by GitBox <gi...@apache.org>.

kezhenxu94 commented on code in PR #9303:
URL: https://github.com/apache/skywalking/pull/9303#discussion_r912998777


##########
docs/en/changes/changes.md:
##########
@@ -15,6 +15,8 @@
 * Add component ID(128) for Java Hutool plugin.
 * Add Zipkin query exception handler, response error message for illegal arguments.
 * Fix a NullPointerException in the endpoint analysis, which would cause missing MQ-related `LocalSpan` in the trace.
+* Add component ID(7014) for Python Bottle plugin

Review Comment:
   ```suggestion
   * Add component ID(7015) for Python Bottle plugin
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #9303: Add component ID and logo for Python Bottle plugin

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on PR #9303:
URL: https://github.com/apache/skywalking/pull/9303#issuecomment-1173812758

   Why is `skywalking-ui` submodule updated?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org