You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2018/03/29 17:46:01 UTC

[1/4] hbase git commit: HBASE-20302 CatalogJanitor should log the reason why it is disabled (Vishal Khandelwal)

Repository: hbase
Updated Branches:
  refs/heads/branch-1 773af3e0c -> 9a6b6524a
  refs/heads/branch-1.2 0a761c0ae -> 09a7c05fd
  refs/heads/branch-1.3 42f5b2723 -> c5016cb1c
  refs/heads/branch-1.4 85457bd94 -> dadb42db5


HBASE-20302 CatalogJanitor should log the reason why it is disabled (Vishal Khandelwal)


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/9a6b6524
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/9a6b6524
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/9a6b6524

Branch: refs/heads/branch-1
Commit: 9a6b6524a7834af2a945dcc2ebfa325d0e0eb1a5
Parents: 773af3e
Author: Andrew Purtell <ap...@apache.org>
Authored: Thu Mar 29 10:20:34 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Thu Mar 29 10:20:34 2018 -0700

----------------------------------------------------------------------
 .../java/org/apache/hadoop/hbase/master/CatalogJanitor.java     | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/9a6b6524/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
index 00dc4a5..549c38f 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
@@ -117,7 +117,10 @@ public class CatalogJanitor extends ScheduledChore {
           && am.getRegionStates().getRegionsInTransition().size() == 0) {
         scan();
       } else {
-        LOG.warn("CatalogJanitor disabled! Not running scan.");
+        LOG.warn("CatalogJanitor is disabled! Enabled=" + this.enabled.get() +
+          ", maintenanceMode=" + this.services.isInMaintenanceMode() +
+          ", am=" + am + ", failoverCleanupDone=" + (am != null && am.isFailoverCleanupDone()) +
+          ", hasRIT=" + (am != null && am.getRegionStates().getRegionsInTransition().size() == 0));
       }
     } catch (IOException e) {
       LOG.warn("Failed scan of catalog table", e);


[4/4] hbase git commit: HBASE-20302 CatalogJanitor should log the reason why it is disabled (Vishal Khandelwal)

Posted by ap...@apache.org.
HBASE-20302 CatalogJanitor should log the reason why it is disabled (Vishal Khandelwal)

Amending-Author: Andrew Purtell <ap...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/c5016cb1
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/c5016cb1
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/c5016cb1

Branch: refs/heads/branch-1.3
Commit: c5016cb1c4048991e3736417d78c5ffc166f1b56
Parents: 42f5b27
Author: Andrew Purtell <ap...@apache.org>
Authored: Thu Mar 29 10:20:34 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Thu Mar 29 10:33:05 2018 -0700

----------------------------------------------------------------------
 .../main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/c5016cb1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
index 893b108..4a10ba8 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
@@ -116,7 +116,9 @@ public class CatalogJanitor extends ScheduledChore {
           && am.getRegionStates().getRegionsInTransition().size() == 0) {
         scan();
       } else {
-        LOG.warn("CatalogJanitor disabled! Not running scan.");
+        LOG.warn("CatalogJanitor is disabled! Enabled=" + this.enabled.get() +
+          ", am=" + am + ", failoverCleanupDone=" + (am != null && am.isFailoverCleanupDone()) +
+          ", hasRIT=" + (am != null && am.getRegionStates().getRegionsInTransition().size() == 0));
       }
     } catch (IOException e) {
       LOG.warn("Failed scan of catalog table", e);


[3/4] hbase git commit: HBASE-20302 CatalogJanitor should log the reason why it is disabled (Vishal Khandelwal)

Posted by ap...@apache.org.
HBASE-20302 CatalogJanitor should log the reason why it is disabled (Vishal Khandelwal)

Amending-Author: Andrew Purtell <ap...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/09a7c05f
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/09a7c05f
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/09a7c05f

Branch: refs/heads/branch-1.2
Commit: 09a7c05fdc2172b0cae7fa8a89af59c4a4aaf657
Parents: 0a761c0
Author: Andrew Purtell <ap...@apache.org>
Authored: Thu Mar 29 10:20:34 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Thu Mar 29 10:26:56 2018 -0700

----------------------------------------------------------------------
 .../main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/09a7c05f/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
index 893b108..4a10ba8 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
@@ -116,7 +116,9 @@ public class CatalogJanitor extends ScheduledChore {
           && am.getRegionStates().getRegionsInTransition().size() == 0) {
         scan();
       } else {
-        LOG.warn("CatalogJanitor disabled! Not running scan.");
+        LOG.warn("CatalogJanitor is disabled! Enabled=" + this.enabled.get() +
+          ", am=" + am + ", failoverCleanupDone=" + (am != null && am.isFailoverCleanupDone()) +
+          ", hasRIT=" + (am != null && am.getRegionStates().getRegionsInTransition().size() == 0));
       }
     } catch (IOException e) {
       LOG.warn("Failed scan of catalog table", e);


[2/4] hbase git commit: HBASE-20302 CatalogJanitor should log the reason why it is disabled (Vishal Khandelwal)

Posted by ap...@apache.org.
HBASE-20302 CatalogJanitor should log the reason why it is disabled (Vishal Khandelwal)


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/dadb42db
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/dadb42db
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/dadb42db

Branch: refs/heads/branch-1.4
Commit: dadb42db5937d906c81b5b7f1296555b024fdcbd
Parents: 85457bd
Author: Andrew Purtell <ap...@apache.org>
Authored: Thu Mar 29 10:20:34 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Thu Mar 29 10:21:17 2018 -0700

----------------------------------------------------------------------
 .../java/org/apache/hadoop/hbase/master/CatalogJanitor.java     | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/dadb42db/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
index 00dc4a5..549c38f 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
@@ -117,7 +117,10 @@ public class CatalogJanitor extends ScheduledChore {
           && am.getRegionStates().getRegionsInTransition().size() == 0) {
         scan();
       } else {
-        LOG.warn("CatalogJanitor disabled! Not running scan.");
+        LOG.warn("CatalogJanitor is disabled! Enabled=" + this.enabled.get() +
+          ", maintenanceMode=" + this.services.isInMaintenanceMode() +
+          ", am=" + am + ", failoverCleanupDone=" + (am != null && am.isFailoverCleanupDone()) +
+          ", hasRIT=" + (am != null && am.getRegionStates().getRegionsInTransition().size() == 0));
       }
     } catch (IOException e) {
       LOG.warn("Failed scan of catalog table", e);