You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "kunwp1 (via GitHub)" <gi...@apache.org> on 2026/03/13 21:49:59 UTC

[PR] fix: Optimized IcebergDocument.hasNext() to reduce catalog round-trips [texera]

kunwp1 opened a new pull request, #4293:
URL: https://github.com/apache/texera/pull/4293

   <!--
   Thanks for sending a pull request (PR)! Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
        [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
     2. Ensure you have added or run the appropriate tests for your PR
     3. If the PR is work in progress, mark it a draft on GitHub.
     4. Please write your PR title to summarize what this PR proposes, we 
       are following Conventional Commits style for PR titles as well.
     5. Be sure to keep the PR description updated to reflect all changes.
   -->
   
   ### What changes were proposed in this PR?
   <!--
   Please clarify what changes you are proposing. The purpose of this section 
   is to outline the changes. Here are some tips for you:
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
     3. If it is a refactoring, clarify what has been changed.
     3. It would be helpful to include a before-and-after comparison using 
        screenshots or GIFs.
     4. Please consider writing useful notes for better and faster reviews.
   -->
   
   This PR addresses #4289 by optimizing `IcebergDocument.hasNext()` to minimize redundant catalog round-trips. By introducing a guard condition, we ensure `seekToUsableFile()` and its subsequent catalog calls are only triggered when the current record iterator is fully exhausted.
   
   1. If the current file has more records, return `true` immediately.
   2. Only if the current file is exhausted, check `usableFileIterator`.
   3. Only if `usableFileIterator` is also empty, call `seekToUsableFile()`.
   
   ### Any related issues, documentation, discussions?
   <!--
   Please use this section to link other resources if not mentioned already.
     1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves #1234`
        or `Closes #1234`. If it is only related, simply mention the issue number.
     2. If there is design documentation, please add the link.
     3. If there is a discussion in the mailing list, please add the link.
   -->
   
   Fix #4289
   
   ### How was this PR tested?
   <!--
   If tests were added, say they were added here. Or simply mention that if the PR 
   is tested with existing test cases.  Make sure to include/update test cases that
   check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how
   you tested step by step, ideally copy and paste-able, so that other reviewers can
   test and check, and descendants can verify in the future. If tests were not added, 
   please describe why they were not added and/or why it was difficult to add. 
   -->
   1. Import and use [Untitled workflow (9).json](https://github.com/user-attachments/files/25983397/Untitled.workflow.9.json).
   2. Use a CSV file containing 1M records.
   3. Set `storage.iceberg.table.commit.batch-size` to 1M (matching the total record count).
   4. Compare the performance before fix and after fix. For me it was 2m 45s vs 36s.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
   please include the phrase: 'Generated-by: ' followed by the name of the tool 
   and its version. If no, write 'No'. 
   Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
   -->
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: reduce catalog round-trips in `IcebergDocument.hasNext()` to improve result read performance [texera]

Posted by "kunwp1 (via GitHub)" <gi...@apache.org>.
kunwp1 merged PR #4293:
URL: https://github.com/apache/texera/pull/4293


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: reduce catalog round-trips in `IcebergDocument.hasNext()` to improve result read performance [texera]

Posted by "kunwp1 (via GitHub)" <gi...@apache.org>.
kunwp1 commented on PR #4293:
URL: https://github.com/apache/texera/pull/4293#issuecomment-4070161113

   > > > Scala side LGTM! Can you also check the python side's iceberg document's corresponding logic, change it and teset it?
   > > 
   > > 
   > > I checked the python side but seems like we don't have such corresponding logic. Can you confirm?
   > 
   > Under this folder: https://github.com/apache/texera/tree/main/amber/src/main/python/core/storage/iceberg
   > 
   > For example: https://github.com/apache/texera/blob/main/amber/src/main/python/core/storage/iceberg/iceberg_document.py and
   
   I checked those files and they don't have the problematic logic. Seems like the implementation on the python side is different.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: reduce catalog round-trips in `IcebergDocument.hasNext()` to improve result writes performance [texera]

Posted by "kunwp1 (via GitHub)" <gi...@apache.org>.
kunwp1 commented on PR #4293:
URL: https://github.com/apache/texera/pull/4293#issuecomment-4069965134

   > Scala side LGTM! Can you also check the python side's iceberg document's corresponding logic, change it and teset it?
   
   I checked the python side but seems like we don't have such corresponding logic. Can you confirm? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Optimized IcebergDocument.hasNext() to reduce catalog round-trips [texera]

Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #4293:
URL: https://github.com/apache/texera/pull/4293#issuecomment-4059319566

   @Xiao-zhen-Liu @bobbai00 Please review it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: reduce catalog round-trips in `IcebergDocument.hasNext()` to improve result read performance [texera]

Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on PR #4293:
URL: https://github.com/apache/texera/pull/4293#issuecomment-4070142196

   > > Scala side LGTM! Can you also check the python side's iceberg document's corresponding logic, change it and teset it?
   > 
   > I checked the python side but seems like we don't have such corresponding logic. Can you confirm?
   
   Under this folder: https://github.com/apache/texera/tree/main/amber/src/main/python/core/storage/iceberg
   
   For example: 
   https://github.com/apache/texera/blob/main/amber/src/main/python/core/storage/iceberg/iceberg_document.py and 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org