You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/19 13:04:24 UTC
[GitHub] [flink] godfreyhe opened a new pull request #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
godfreyhe opened a new pull request #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904
## What is the purpose of the change
*reason: in sql client, CLI client do cancel query operaiton through void cancelQuery(String sessionId, String resultId) method in Executor. However, the resultId is a random UUID, is not the job id.
solution: changes the non-blocking deployment to blocking deployment in LocalExecutor#executeQueryInternal method, and then we can get jobId from JobClient, and then use it as resultId. The parameter of DynamicResult#startRetrieval method should also be changed from ProgramDeployer to JobClient, like void startRetrieval(JobClient jobClient);*
## Brief change log
- *changes the non-blocking deployment to blocking deployment in LocalExecutor#executeQueryInternal method*
- *changes the DynamicResult#startRetrieval method's parameter from ProgramDeployer to JobClient *
## Verifying this change
This change is verified by manual testing.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145110835 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145171018 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:202059d5e5c772b1b11ee50b9715b216b6ddeaad Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:202059d5e5c772b1b11ee50b9715b216b6ddeaad
-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145110835) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479)
* 8637d733546f1863b30ecf78766961a4b4471482 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145171018) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500)
* 202059d5e5c772b1b11ee50b9715b216b6ddeaad UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145110835 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145171018 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:202059d5e5c772b1b11ee50b9715b216b6ddeaad Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147163955 TriggerType:PUSH TriggerID:202059d5e5c772b1b11ee50b9715b216b6ddeaad
Hash:202059d5e5c772b1b11ee50b9715b216b6ddeaad Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4765 TriggerType:PUSH TriggerID:202059d5e5c772b1b11ee50b9715b216b6ddeaad
Hash:6d89ef84c8f0673d93a1048350b302e7d24d7484 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:6d89ef84c8f0673d93a1048350b302e7d24d7484
-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145110835) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479)
* 8637d733546f1863b30ecf78766961a4b4471482 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145171018) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500)
* 202059d5e5c772b1b11ee50b9715b216b6ddeaad Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147163955) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4765)
* 6d89ef84c8f0673d93a1048350b302e7d24d7484 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145110835 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145171018 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:202059d5e5c772b1b11ee50b9715b216b6ddeaad Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147163955 TriggerType:PUSH TriggerID:202059d5e5c772b1b11ee50b9715b216b6ddeaad
Hash:202059d5e5c772b1b11ee50b9715b216b6ddeaad Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4765 TriggerType:PUSH TriggerID:202059d5e5c772b1b11ee50b9715b216b6ddeaad
Hash:6d89ef84c8f0673d93a1048350b302e7d24d7484 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149745708 TriggerType:PUSH TriggerID:6d89ef84c8f0673d93a1048350b302e7d24d7484
Hash:6d89ef84c8f0673d93a1048350b302e7d24d7484 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5335 TriggerType:PUSH TriggerID:6d89ef84c8f0673d93a1048350b302e7d24d7484
-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145110835) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479)
* 8637d733546f1863b30ecf78766961a4b4471482 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145171018) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500)
* 202059d5e5c772b1b11ee50b9715b216b6ddeaad Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147163955) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4765)
* 6d89ef84c8f0673d93a1048350b302e7d24d7484 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149745708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5335)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbfc485ecea3aec8bc0054ca8bacb310b417c5dc",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/145110835",
"triggerID" : "dbfc485ecea3aec8bc0054ca8bacb310b417c5dc",
"triggerType" : "PUSH"
}, {
"hash" : "dbfc485ecea3aec8bc0054ca8bacb310b417c5dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479",
"triggerID" : "dbfc485ecea3aec8bc0054ca8bacb310b417c5dc",
"triggerType" : "PUSH"
}, {
"hash" : "8637d733546f1863b30ecf78766961a4b4471482",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/145171018",
"triggerID" : "8637d733546f1863b30ecf78766961a4b4471482",
"triggerType" : "PUSH"
}, {
"hash" : "8637d733546f1863b30ecf78766961a4b4471482",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500",
"triggerID" : "8637d733546f1863b30ecf78766961a4b4471482",
"triggerType" : "PUSH"
}, {
"hash" : "202059d5e5c772b1b11ee50b9715b216b6ddeaad",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147163955",
"triggerID" : "202059d5e5c772b1b11ee50b9715b216b6ddeaad",
"triggerType" : "PUSH"
}, {
"hash" : "202059d5e5c772b1b11ee50b9715b216b6ddeaad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4765",
"triggerID" : "202059d5e5c772b1b11ee50b9715b216b6ddeaad",
"triggerType" : "PUSH"
}, {
"hash" : "6d89ef84c8f0673d93a1048350b302e7d24d7484",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149745708",
"triggerID" : "6d89ef84c8f0673d93a1048350b302e7d24d7484",
"triggerType" : "PUSH"
}, {
"hash" : "6d89ef84c8f0673d93a1048350b302e7d24d7484",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5335",
"triggerID" : "6d89ef84c8f0673d93a1048350b302e7d24d7484",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145110835) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479)
* 8637d733546f1863b30ecf78766961a4b4471482 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145171018) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500)
* 202059d5e5c772b1b11ee50b9715b216b6ddeaad Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147163955) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4765)
* 6d89ef84c8f0673d93a1048350b302e7d24d7484 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149745708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5335)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145110835 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145110835) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479)
* 8637d733546f1863b30ecf78766961a4b4471482 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145110835 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145171018 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:202059d5e5c772b1b11ee50b9715b216b6ddeaad Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147163955 TriggerType:PUSH TriggerID:202059d5e5c772b1b11ee50b9715b216b6ddeaad
Hash:202059d5e5c772b1b11ee50b9715b216b6ddeaad Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4765 TriggerType:PUSH TriggerID:202059d5e5c772b1b11ee50b9715b216b6ddeaad
-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145110835) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479)
* 8637d733546f1863b30ecf78766961a4b4471482 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145171018) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500)
* 202059d5e5c772b1b11ee50b9715b216b6ddeaad Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147163955) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4765)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10904: [FLINK-15669] [sql
client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576002761
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 644635ad89addd67abb250964b5c6fcd1b049694 (Sun Jan 19 13:06:29 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15669).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on issue #10904: [FLINK-15669] [sql
client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-588584960
Thanks for the suggestion @docete .
Currently we can't get large result set based on `Accumulator`. so I think it's a temporary solution , we prepare to use [`Table#collect`](https://issues.apache.org/jira/browse/FLINK-14807) to solve this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145110835 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145171018 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145110835) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479)
* 8637d733546f1863b30ecf78766961a4b4471482 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145171018) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145110835 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145110835) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on issue #10904: [FLINK-15669] [sql
client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-581303612
cc @docete @twalthr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145110835 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145110835) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] docete commented on a change in pull request #10904:
[FLINK-15669] [sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
docete commented on a change in pull request #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#discussion_r375688490
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/result/CollectStreamResult.java
##########
@@ -86,13 +86,12 @@ public CollectStreamResult(
}
@Override
- public void startRetrieval(ProgramDeployer deployer) {
+ public void startRetrieval(JobClient jobClient) {
// start listener thread
retrievalThread.start();
- jobExecutionResultFuture = deployer
- .deploy()
- .thenCompose(jobClient -> jobClient.getJobExecutionResult(classLoader))
+ jobExecutionResultFuture = CompletableFuture.completedFuture(jobClient)
+ .thenCompose(client -> client.getJobExecutionResult(classLoader))
Review comment:
Should change the exception message since we only retrieve results here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
godfreyhe edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-606989951
@twalthr, I verified the scenario you specified, It works. I have a [screenshot](https://ae02.alicdn.com/kf/H2649c753a057457aaa661d71b7f3e351Y.gif), correct me if I misunderstand what you mean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on issue #10904: [FLINK-15669] [sql
client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-600037989
agree with you @twalthr, it would improve user experience. I‘d like to further investigate this issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145110835 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145171018 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:202059d5e5c772b1b11ee50b9715b216b6ddeaad Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147163955 TriggerType:PUSH TriggerID:202059d5e5c772b1b11ee50b9715b216b6ddeaad
Hash:202059d5e5c772b1b11ee50b9715b216b6ddeaad Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4765 TriggerType:PUSH TriggerID:202059d5e5c772b1b11ee50b9715b216b6ddeaad
Hash:6d89ef84c8f0673d93a1048350b302e7d24d7484 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149745708 TriggerType:PUSH TriggerID:6d89ef84c8f0673d93a1048350b302e7d24d7484
Hash:6d89ef84c8f0673d93a1048350b302e7d24d7484 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5335 TriggerType:PUSH TriggerID:6d89ef84c8f0673d93a1048350b302e7d24d7484
-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145110835) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479)
* 8637d733546f1863b30ecf78766961a4b4471482 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145171018) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500)
* 202059d5e5c772b1b11ee50b9715b216b6ddeaad Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147163955) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4765)
* 6d89ef84c8f0673d93a1048350b302e7d24d7484 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149745708) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5335)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] docete commented on a change in pull request #10904:
[FLINK-15669] [sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
docete commented on a change in pull request #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#discussion_r375690809
##########
File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
##########
@@ -1270,4 +1362,22 @@ private void executeAndVerifySinkResult(
}
return actualResults;
}
+
+ private JobStatus getJobStatus(LocalExecutor executor, String sessionId, JobID jobId) {
+ final ExecutionContext<?> context = executor.getExecutionContext(sessionId);
+ return getJobStatusInternal(context, jobId);
+ }
+
+ private <T> JobStatus getJobStatusInternal(ExecutionContext<T> context, JobID jobId) {
+ // stop Flink job
Review comment:
useless comments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] docete commented on a change in pull request #10904:
[FLINK-15669] [sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
docete commented on a change in pull request #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#discussion_r375687425
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
##########
@@ -657,11 +654,23 @@ public ProgramTargetDescriptor executeUpdate(String sessionId, String statement)
final ProgramDeployer deployer = new ProgramDeployer(
configuration, jobName, pipeline);
+ JobClient jobClient;
+ // blocking deployment
+ try {
+ jobClient = deployer.deploy().get();
+ } catch (Exception e) {
+ throw new SqlExecutionException("Error running SQL job.", e);
Review comment:
`Error while submitting SQL job` is more accurate for the exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145110835 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145171018 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145110835) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479)
* 8637d733546f1863b30ecf78766961a4b4471482 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145171018) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10904: [FLINK-15669] [sql
client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145110835 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145110835) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on issue #10904: [FLINK-15669] [sql
client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-613203066
@twalthr have a look if you have time ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] docete commented on issue #10904: [FLINK-15669] [sql
client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
docete commented on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-589452927
@godfreyhe LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145110835 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145171018 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:202059d5e5c772b1b11ee50b9715b216b6ddeaad Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147163955 TriggerType:PUSH TriggerID:202059d5e5c772b1b11ee50b9715b216b6ddeaad
Hash:202059d5e5c772b1b11ee50b9715b216b6ddeaad Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4765 TriggerType:PUSH TriggerID:202059d5e5c772b1b11ee50b9715b216b6ddeaad
-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145110835) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479)
* 8637d733546f1863b30ecf78766961a4b4471482 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145171018) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500)
* 202059d5e5c772b1b11ee50b9715b216b6ddeaad Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147163955) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4765)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on issue #10904: [FLINK-15669] [sql
client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-606989951
@Timo, I verified the scenario you specified, It works. I have a [screenshot](https://ae02.alicdn.com/kf/H2649c753a057457aaa661d71b7f3e351Y.gif), correct me if I misunderstand what you mean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr commented on issue #10904: [FLINK-15669] [sql
client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
twalthr commented on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-599961998
Thanks for the PR @godfreyhe. The PR definitely solves one issue that was introduced in Flink 1.10. However, I'm still not happy with the current user experience. Compare the current SQL Client with Flink 1.9. At any point in time, a user could cancel a query and go back to the command line prompt. This is still not possible.
For example: start the Client without a running/reachable Flink cluster and run a `SELECT`. In Flink 1.9 you could cancel the result retrieval at any time instead of waiting 60 seconds to get a cryptic exception. Could you further investigate this issue? That would be very helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbfc485ecea3aec8bc0054ca8bacb310b417c5dc",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/145110835",
"triggerID" : "dbfc485ecea3aec8bc0054ca8bacb310b417c5dc",
"triggerType" : "PUSH"
}, {
"hash" : "dbfc485ecea3aec8bc0054ca8bacb310b417c5dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479",
"triggerID" : "dbfc485ecea3aec8bc0054ca8bacb310b417c5dc",
"triggerType" : "PUSH"
}, {
"hash" : "8637d733546f1863b30ecf78766961a4b4471482",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/145171018",
"triggerID" : "8637d733546f1863b30ecf78766961a4b4471482",
"triggerType" : "PUSH"
}, {
"hash" : "8637d733546f1863b30ecf78766961a4b4471482",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500",
"triggerID" : "8637d733546f1863b30ecf78766961a4b4471482",
"triggerType" : "PUSH"
}, {
"hash" : "202059d5e5c772b1b11ee50b9715b216b6ddeaad",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147163955",
"triggerID" : "202059d5e5c772b1b11ee50b9715b216b6ddeaad",
"triggerType" : "PUSH"
}, {
"hash" : "202059d5e5c772b1b11ee50b9715b216b6ddeaad",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4765",
"triggerID" : "202059d5e5c772b1b11ee50b9715b216b6ddeaad",
"triggerType" : "PUSH"
}, {
"hash" : "6d89ef84c8f0673d93a1048350b302e7d24d7484",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149745708",
"triggerID" : "6d89ef84c8f0673d93a1048350b302e7d24d7484",
"triggerType" : "PUSH"
}, {
"hash" : "6d89ef84c8f0673d93a1048350b302e7d24d7484",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5335",
"triggerID" : "6d89ef84c8f0673d93a1048350b302e7d24d7484",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6d89ef84c8f0673d93a1048350b302e7d24d7484 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149745708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5335)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10904: [FLINK-15669]
[sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#issuecomment-576004529
<!--
Meta data
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145110835 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479 TriggerType:PUSH TriggerID:dbfc485ecea3aec8bc0054ca8bacb310b417c5dc
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145171018 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
Hash:8637d733546f1863b30ecf78766961a4b4471482 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500 TriggerType:PUSH TriggerID:8637d733546f1863b30ecf78766961a4b4471482
-->
## CI report:
* dbfc485ecea3aec8bc0054ca8bacb310b417c5dc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145110835) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4479)
* 8637d733546f1863b30ecf78766961a4b4471482 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145171018) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4500)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] docete commented on a change in pull request #10904:
[FLINK-15669] [sql client] fix SQL client can't cancel flink job
Posted by GitBox <gi...@apache.org>.
docete commented on a change in pull request #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#discussion_r375688351
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/result/MaterializedCollectBatchResult.java
##########
@@ -76,10 +77,9 @@ public boolean isMaterialized() {
}
@Override
- public void startRetrieval(ProgramDeployer deployer) {
- deployer
- .deploy()
- .thenCompose(jobClient -> jobClient.getJobExecutionResult(classLoader))
+ public void startRetrieval(JobClient jobClient) {
+ CompletableFuture.completedFuture(jobClient)
+ .thenCompose(client -> client.getJobExecutionResult(classLoader))
Review comment:
Should change the exception message since we only retrieve results here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services