[GitHub] [airflow] nuclearpinguin commented on a change in pull request #6749: [AIRFLOW-6193] Do not use asserts in Airflow main code

[GitBox <gi...@apache.org>]

nuclearpinguin commented on a change in pull request #6749: [AIRFLOW-6193] Do not use asserts in Airflow main code
URL: https://github.com/apache/airflow/pull/6749#discussion_r355178669
 
 

 ##########
 File path: airflow/executors/kubernetes_executor.py
 ##########
 @@ -863,9 +876,12 @@ def _flush_result_queue(self) -> None:
 
     def end(self) -> None:
         """Called when the executor shuts down"""
-        assert self.task_queue, NOT_STARTED_MESSAGE
-        assert self.result_queue, NOT_STARTED_MESSAGE
-        assert self.kube_scheduler, NOT_STARTED_MESSAGE
+        if not self.task_queue:
 
 Review comment:
   ```suggestion
           if not (self.task_queue and self.queue_result and self.kube_scheduler):
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services