[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #7534: Remove usages of S3 fields from AwsProperties within s3 package

["amogh-jahagirdar (via GitHub)" <gi...@apache.org>]

amogh-jahagirdar commented on code in PR #7534:
URL: https://github.com/apache/iceberg/pull/7534#discussion_r1186424581


##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -101,60 +100,59 @@ public S3FileIO() {
   }
 
   /**
-   * Constructor with custom s3 supplier and default AWS properties.
+   * Constructor with custom s3 supplier and S3 fileIO properties.

Review Comment:
   Nit on naming, can we just stick to the form `S3FileIO` in the comments as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org