You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/27 18:28:38 UTC

[GitHub] [helix] jiajunwang commented on a change in pull request #1485: Add offline node purge timeout in cluster config

jiajunwang commented on a change in pull request #1485:
URL: https://github.com/apache/helix/pull/1485#discussion_r512932713



##########
File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java
##########
@@ -128,7 +128,9 @@
     // offline for more than this specified time period, it's treated as offline for the rest of
     // the maintenance mode's duration even when it comes online.
     // The unit is milliseconds.
-    OFFLINE_NODE_TIME_OUT_FOR_MAINTENANCE_MODE
+    OFFLINE_NODE_TIME_OUT_FOR_MAINTENANCE_MODE,
+
+    OFFLINE_NODE_TIME_OUT_FOR_PURGE

Review comment:
       nit, comment to explain the option please




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org