You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/06/12 23:50:00 UTC

[Impala-ASF-CR] IMPALA-8659: Allow self-RPCs for KRPC to go via loopback

Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13592

to look at the new patch set (#7).

Change subject: IMPALA-8659: Allow self-RPCs for KRPC to go via loopback
......................................................................

IMPALA-8659: Allow self-RPCs for KRPC to go via loopback

Adds a flag --rpc_use_loopback that causes two differences
in behaviour when enabled:
1. KRPC will listen on all interfaces, i.e. bind the socket
   to INADDR_ANY.
2. KRPC RPCs to --hostname are sent to 127.0.0.1 instead of
   the IP (maybe external) that --hostname resolves to.

There is no change in default behaviour, except in containers,
where this flag is enabled by default.

Testing:
* Added a custom cluster test, which runs in exhaustive,
  as a sanity test for the behaviour of the flag.

Change-Id: I9dbd477769ed49c05e624f06da4e51afaaf1670d
---
M be/src/rpc/rpc-mgr.cc
M be/src/rpc/rpc-mgr.inline.h
M be/src/util/network-util.cc
M be/src/util/network-util.h
M docker/coord_exec/Dockerfile
M docker/coordinator/Dockerfile
M docker/executor/Dockerfile
A tests/custom_cluster/test_krpc_options.py
8 files changed, 78 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/13592/7
-- 
To view, visit http://gerrit.cloudera.org:8080/13592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9dbd477769ed49c05e624f06da4e51afaaf1670d
Gerrit-Change-Number: 13592
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>