You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/06/19 18:59:38 UTC

Review Request 70900: Updated an equality operator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70900/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9821
    https://issues.apache.org/jira/browse/MESOS-9821


Repository: mesos


Description
-------

This patch updates the equality operator for the `Task`
message to make use of the `MessageDifferencer`, which
will eliminate the need to update the operator
implementation when new fields are added in the future.


Diffs
-----

  src/common/type_utils.cpp ef1b3ea15cde1c7a8e0735fb9d7566dd1fd2cfdb 


Diff: https://reviews.apache.org/r/70900/diff/1/


Testing
-------

Testing details at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 70900: Updated an equality operator.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70900/#review216324
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On July 1, 2019, 12:52 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70900/
> -----------------------------------------------------------
> 
> (Updated July 1, 2019, 12:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9821
>     https://issues.apache.org/jira/browse/MESOS-9821
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the equality operator for the `Task`
> message to include two missing conditions. An equality
> operator for `HealthCheck` is also added to make this
> possible.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d 
>   src/common/type_utils.cpp a7eb0e922c5d6d095410b058955088dfafba3aa9 
> 
> 
> Diff: https://reviews.apache.org/r/70900/diff/2/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70900: Updated an equality operator.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70900/
-----------------------------------------------------------

(Updated July 1, 2019, 7:52 p.m.)


Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9821
    https://issues.apache.org/jira/browse/MESOS-9821


Repository: mesos


Description (updated)
-------

This patch updates the equality operator for the `Task`
message to include two missing conditions. An equality
operator for `HealthCheck` is also added to make this
possible.


Diffs (updated)
-----

  include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d 
  src/common/type_utils.cpp a7eb0e922c5d6d095410b058955088dfafba3aa9 


Diff: https://reviews.apache.org/r/70900/diff/2/

Changes: https://reviews.apache.org/r/70900/diff/1-2/


Testing
-------

Testing details at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 70900: Updated an equality operator.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70900/#review216054
-----------------------------------------------------------




src/common/type_utils.cpp
Line 573 (original)
<https://reviews.apache.org/r/70900/#comment303028>

    I think this is the one case where the MessageDifferencer will not work.
    
    I've played around with one here: https://reviews.apache.org/r/65541/
    
    But that patch (experimental) also did not handle Resources because they are a bit tricky to fit.


- Joseph Wu


On June 19, 2019, 11:59 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70900/
> -----------------------------------------------------------
> 
> (Updated June 19, 2019, 11:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9821
>     https://issues.apache.org/jira/browse/MESOS-9821
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the equality operator for the `Task`
> message to make use of the `MessageDifferencer`, which
> will eliminate the need to update the operator
> implementation when new fields are added in the future.
> 
> 
> Diffs
> -----
> 
>   src/common/type_utils.cpp ef1b3ea15cde1c7a8e0735fb9d7566dd1fd2cfdb 
> 
> 
> Diff: https://reviews.apache.org/r/70900/diff/1/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>