[GitHub] [iceberg] yyanyy commented on a change in pull request #2520: Core: add key_metadata in ManifestFile

[GitBox <gi...@apache.org>]

yyanyy commented on a change in pull request #2520:
URL: https://github.com/apache/iceberg/pull/2520#discussion_r622668587



##########
File path: api/src/main/java/org/apache/iceberg/ManifestFile.java
##########
@@ -179,6 +181,13 @@ default boolean hasDeletedFiles() {
    */
   List<PartitionFieldSummary> partitions();
 
+  /**
+   * Returns metadata about how this manifest file is encrypted, or null if the file is stored in plain text.
+   */
+  default ByteBuffer keyMetadata() {

Review comment:
       I was wondering about this too, should we make this a struct with name like `encryptionContext` or something so that if we only plan to add new things in future (e.g. KEK id for double wrapping?), we can collect them in a single struct; and to workaround the problem of having to unwrap two layers to reach this buffer from `ManifestFile` we may return `EncryptionKeyMetadata` here, and potentially extend `EncryptionKeyMetadata` to have more fields when needed in the future. Or will this binary buffer free formed and could contain whatever information needed if the right encryption manager is used? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org