You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/09 07:06:13 UTC
[GitHub] [arrow] edponce commented on pull request #11113: ARROW-13937: [C++][Compute] Add explicit output values to sign function for unsigned inputs
edponce commented on pull request #11113:
URL: https://github.com/apache/arrow/pull/11113#issuecomment-915821085
After revisiting the `sign` compute function, I noticed that kernels are registered with `Int8Type` for integral types and corresponding floating-point for floating-point types. The kernels' `Call` methods are stated to be enabled if they return unsigned int, signed int, and floating-point. The unsigned int kernel is therefore never invoked. To fix this, the `enable_if` checks should be done against `Arg0` or `Arg1`.
Also, shouldn't the floating-point kernels also return the same int type for `sign` function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org