[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #515: MINIFICPP-646 - Re-evaluate passing attributes. Potentially deprecate…

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #515: MINIFICPP-646 - Re-evaluate passing attributes. Potentially deprecate…
URL: https://github.com/apache/nifi-minifi-cpp/pull/515#discussion_r266521860
 
 

 ##########
 File path: nanofi/include/core/cstructs.h
 ##########
 @@ -89,8 +89,7 @@ typedef struct processor_context processor_context;
 
 typedef struct {
   const char *key;
-  void *value;
-  size_t value_size;
+  const char *value;
 
 Review comment:
   My idea here was to make sure that whatever we store is null-terminated.
   We provide API to add non-terminated str with length, (something like strncpy), but inside store null-terminated things.
   
   Two reasons behind:
   -no need to store len in internal structures
   -whatever we return is null-terminated, which makes it easy to copy/log
   
   In my opinion this leads to a more compact  and cleaner API, but I can be convinced about the opposite way, too. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services