You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/05/28 10:22:24 UTC

[GitHub] [dolphinscheduler] CalvinKirs opened a new issue #3512: [refactor][Test*] refactor test

CalvinKirs opened a new issue #3512:
URL: https://github.com/apache/dolphinscheduler/issues/3512


   For refactoring that does not conform to the unit test specification, see the benchmark document: https://github.com/apache/incubator-dolphinscheduler-website/pull/165
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] CalvinKirs commented on issue #3512: [refactor][Test*] refactor test

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #3512:
URL: https://github.com/apache/dolphinscheduler/issues/3512#issuecomment-850320515


   We still have many UTs that are not good enough. What we expect is to ensure the single and isolation of testing, otherwise, such problems will be exposed: I modified the registry plugin. Because of UT, most of the UTs need to be modified again.
   
   At present, the server module needs to be refactored as soon as possible. Whoever is interested can choose what they like to refactor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on issue #3512: [refactor][Test*] refactor test

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #3512:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3512#issuecomment-674882334


   @dailidong @qiaozhanwei hello, can you review it for me?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] CalvinKirs removed a comment on issue #3512: [refactor][Test*] refactor test

Posted by GitBox <gi...@apache.org>.
CalvinKirs removed a comment on issue #3512:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3512#issuecomment-674882334


   @dailidong @qiaozhanwei hello, can you review it for me?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] dailidong closed issue #3512: [refactor][Test*] refactor test

Posted by GitBox <gi...@apache.org>.
dailidong closed issue #3512:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3512


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org