[GitHub] [incubator-nuttx] davids5 edited a comment on issue #1: imxrt fixes

[GitBox <gi...@apache.org>]

davids5 edited a comment on issue #1: imxrt fixes 
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568473865
 
 
   @btashton 
   
   > @davids5 This touches some of the same IO stuff that I have been working on on the imxrt platform, some of the changes are style. Did you make these changes via one of the existing tools, or was this manual. I want to make sure my changes apply cleanly on top of this. For now I will carry this in my tree.
   
   yeah - we really should talk this through. I had a very detailed discussion on yahoo on what we had learned from the STM32  organically grown nightmare.  
   
   The gist of it is: There are clear patterns that should be use when there is a chip family.
   
   @mubes make some great strides in this on the RT, but took some shortcuts when the imxrt20 came in. We should **not** follow that pattern.
   
   All the gpio tables need to broken out and the included like the clockconfig does STM32 or the dasiy does n the imxrt. 
   
   #ifddef rash has to be avoided or kept to a minimum.  It use to be before the 20 commit. 
   Scope has to be be maintained.
   
   Let' plan a call then bring it back to the list.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services