You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/03/16 21:37:11 UTC
[GitHub] [helix] xyuanlu opened a new pull request #1986: Read cloud config from zk and propagate to HelixManagerProperty in ZkHelixManager constructor
xyuanlu opened a new pull request #1986:
URL: https://github.com/apache/helix/pull/1986
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
#1985
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Helix user notice that when ZooScalability is enabled, property configured helix cloud participant could not auto register in cluster. This is because when ZooScalability is enabled, Helix need user to pass a cloudConfig object when initiating ZkHelixManager. When user did not set cloudConfig, it will cause nullptr error when reading cloudConfig in ParticipantManager.autoJoin().
This change reads cloudConfig from Zookeeper in ZkHelixManager constructor and propagate to HelixManagerProperty in ZkHelixManager constructor.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #1986: Read cloud config from zk and propagate to HelixManagerProperty in ZkHelixManager constructor
Posted by GitBox <gi...@apache.org>.
desaikomal commented on pull request #1986:
URL: https://github.com/apache/helix/pull/1986#issuecomment-1074030316
Test case looks good.. is there any other place where we may need to pull out TestZkHelixManager ?
Overall LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on a change in pull request #1986: Read cloud config from zk and propagate to HelixManagerProperty in ZkHelixManager constructor
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on a change in pull request #1986:
URL: https://github.com/apache/helix/pull/1986#discussion_r830401436
##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -269,7 +269,10 @@ public ZKHelixManager(String clusterName, String instanceName, InstanceType inst
}
_stateListener = stateListener;
+ // read cloud config from ZK and set cloudConfig in HelixManagerProperty
_helixManagerProperty = helixManagerProperty;
+ _helixManagerProperty
+ .setHelixCloudProperty(HelixPropertyFactory.getCloudConfig(_zkAddress, _clusterName));
Review comment:
Maybe not related, what the difference between this and using `_configAccessor.getCloudConfig()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #1986: Read cloud config from zk and propagate to HelixManagerProperty in ZkHelixManager constructor
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on pull request #1986:
URL: https://github.com/apache/helix/pull/1986#issuecomment-1075515283
This PR is ready to be merged. Approved by @junkaixue // Thanks!!
Commit message:
Read cloud config from zk and propagate to HelixManagerProperty in ZkHelixManager constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on a change in pull request #1986: Read cloud config from zk and propagate to HelixManagerProperty in ZkHelixManager constructor
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on a change in pull request #1986:
URL: https://github.com/apache/helix/pull/1986#discussion_r830538331
##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -269,7 +269,10 @@ public ZKHelixManager(String clusterName, String instanceName, InstanceType inst
}
_stateListener = stateListener;
+ // read cloud config from ZK and set cloudConfig in HelixManagerProperty
_helixManagerProperty = helixManagerProperty;
+ _helixManagerProperty
+ .setHelixCloudProperty(HelixPropertyFactory.getCloudConfig(_zkAddress, _clusterName));
Review comment:
`_configAccessor.getCloudConfig()` also returns cloud config. However, _configAccessor is initiated in `connect()` not the zkHelixManager constructor. So in constructor we need to use `HelixPropertyFactory.getCloudConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue closed pull request #1986: Read cloud config from zk and propagate to HelixManagerProperty in ZkHelixManager constructor
Posted by GitBox <gi...@apache.org>.
junkaixue closed pull request #1986:
URL: https://github.com/apache/helix/pull/1986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #1986: Read cloud config from zk and propagate to HelixManagerProperty in ZkHelixManager constructor
Posted by GitBox <gi...@apache.org>.
desaikomal commented on pull request #1986:
URL: https://github.com/apache/helix/pull/1986#issuecomment-1069793224
not an expert but looks good to me.. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #1986: Read cloud config from zk and propagate to HelixManagerProperty in ZkHelixManager constructor
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on pull request #1986:
URL: https://github.com/apache/helix/pull/1986#issuecomment-1074184740
> Test case looks good.. is there any other place where we may need to pull out TestZkHelixManager ? Overall LGTM
Thanks for the review.
The class TestZkHelixManager is only for retrieving managementProperty. I think other test class could implement their own local class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org