You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Xander Uiterlinden (Created) (JIRA)" <ji...@apache.org> on 2011/10/25 17:22:32 UTC
[jira] [Created] (FELIX-3186) Adapter services do not get their
adapted services transparently replaced when an aspect is added to them.
Adapter services do not get their adapted services transparently replaced when an aspect is added to them.
----------------------------------------------------------------------------------------------------------
Key: FELIX-3186
URL: https://issues.apache.org/jira/browse/FELIX-3186
Project: Felix
Issue Type: Bug
Components: Dependency Manager
Affects Versions: dependencymanager-3.0.0
Environment: mac-osx
Reporter: Xander Uiterlinden
Fix For: dependencymanager-3.0.0
Attachments: AspectAdapterTest.java
A service consumer consumes an adapter service. The adapter service adapts a service provider.
An aspect is added to the service provider. This should not impact the service consumer.
Expected behavior is transparent replacement of the service the adapter adapts with the aspect service.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3186) Adapter services do not get their
adapted services transparently replaced when an aspect is added to them.
Posted by "Xander Uiterlinden (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xander Uiterlinden updated FELIX-3186:
--------------------------------------
Attachment: adapteronsomethingwithaspecttestpatch.patch
adapteronsomethingwithaspectpatch.patch
Find the enclosed patch which resolves the issue. It also adds the possibility to provide a swap callback method for an adapter service which is called when the service the adapter adapts is changed due to an aspect becoming (un)available. The modified adapter tests are also included in a separate patch file.
> Adapter services do not get their adapted services transparently replaced when an aspect is added to them.
> ----------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3186
> URL: https://issues.apache.org/jira/browse/FELIX-3186
> Project: Felix
> Issue Type: Bug
> Components: Dependency Manager
> Affects Versions: dependencymanager-3.0.0
> Environment: mac-osx
> Reporter: Xander Uiterlinden
> Labels: bug
> Fix For: dependencymanager-3.0.0
>
> Attachments: AspectAdapterTest.java, adapteronsomethingwithaspectpatch.patch, adapteronsomethingwithaspecttestpatch.patch
>
>
> A service consumer consumes an adapter service. The adapter service adapts a service provider.
> An aspect is added to the service provider. This should not impact the service consumer.
> Expected behavior is transparent replacement of the service the adapter adapts with the aspect service.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-3186) Adapter services do not get their
adapted services transparently replaced when an aspect is added to them.
Posted by "Marcel Offermans (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Offermans resolved FELIX-3186.
-------------------------------------
Resolution: Fixed
Thanks for this extensive patch, Xander. As you can see from the commit log, I applied the patches with some changes, so it probably makes sense that you review my changes.
> Adapter services do not get their adapted services transparently replaced when an aspect is added to them.
> ----------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3186
> URL: https://issues.apache.org/jira/browse/FELIX-3186
> Project: Felix
> Issue Type: Bug
> Components: Dependency Manager
> Affects Versions: dependencymanager-3.0.0
> Environment: mac-osx
> Reporter: Xander Uiterlinden
> Assignee: Marcel Offermans
> Labels: bug
> Fix For: dependencymanager-3.0.0
>
> Attachments: AspectAdapterTest.java, adapteronsomethingwithaspectpatch.patch, adapteronsomethingwithaspecttestpatch.patch
>
>
> A service consumer consumes an adapter service. The adapter service adapts a service provider.
> An aspect is added to the service provider. This should not impact the service consumer.
> Expected behavior is transparent replacement of the service the adapter adapts with the aspect service.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3186) Adapter services do not get their
adapted services transparently replaced when an aspect is added to them.
Posted by "Xander Uiterlinden (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135140#comment-13135140 ]
Xander Uiterlinden commented on FELIX-3186:
-------------------------------------------
The testcase also finishes with a warning which needs to be checked:
WARNING: Invocation of 'added' failed. (java.lang.IllegalStateException: Can only register services while bundle is active or activating.)
> Adapter services do not get their adapted services transparently replaced when an aspect is added to them.
> ----------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3186
> URL: https://issues.apache.org/jira/browse/FELIX-3186
> Project: Felix
> Issue Type: Bug
> Components: Dependency Manager
> Affects Versions: dependencymanager-3.0.0
> Environment: mac-osx
> Reporter: Xander Uiterlinden
> Labels: bug
> Fix For: dependencymanager-3.0.0
>
> Attachments: AspectAdapterTest.java
>
>
> A service consumer consumes an adapter service. The adapter service adapts a service provider.
> An aspect is added to the service provider. This should not impact the service consumer.
> Expected behavior is transparent replacement of the service the adapter adapts with the aspect service.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3186) Adapter services do not get their
adapted services transparently replaced when an aspect is added to them.
Posted by "Xander Uiterlinden (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xander Uiterlinden updated FELIX-3186:
--------------------------------------
Attachment: AspectAdapterTest.java
See attached testcase for reproduction of the issue.
> Adapter services do not get their adapted services transparently replaced when an aspect is added to them.
> ----------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3186
> URL: https://issues.apache.org/jira/browse/FELIX-3186
> Project: Felix
> Issue Type: Bug
> Components: Dependency Manager
> Affects Versions: dependencymanager-3.0.0
> Environment: mac-osx
> Reporter: Xander Uiterlinden
> Labels: bug
> Fix For: dependencymanager-3.0.0
>
> Attachments: AspectAdapterTest.java
>
>
> A service consumer consumes an adapter service. The adapter service adapts a service provider.
> An aspect is added to the service provider. This should not impact the service consumer.
> Expected behavior is transparent replacement of the service the adapter adapts with the aspect service.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FELIX-3186) Adapter services do not get their
adapted services transparently replaced when an aspect is added to them.
Posted by "Marcel Offermans (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Offermans reassigned FELIX-3186:
---------------------------------------
Assignee: Marcel Offermans
> Adapter services do not get their adapted services transparently replaced when an aspect is added to them.
> ----------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3186
> URL: https://issues.apache.org/jira/browse/FELIX-3186
> Project: Felix
> Issue Type: Bug
> Components: Dependency Manager
> Affects Versions: dependencymanager-3.0.0
> Environment: mac-osx
> Reporter: Xander Uiterlinden
> Assignee: Marcel Offermans
> Labels: bug
> Fix For: dependencymanager-3.0.0
>
> Attachments: AspectAdapterTest.java, adapteronsomethingwithaspectpatch.patch, adapteronsomethingwithaspecttestpatch.patch
>
>
> A service consumer consumes an adapter service. The adapter service adapts a service provider.
> An aspect is added to the service provider. This should not impact the service consumer.
> Expected behavior is transparent replacement of the service the adapter adapts with the aspect service.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira