You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/05/05 17:16:59 UTC
[I] Improve parquet ArrayReaderBuilder tests [arrow-rs]
alamb opened a new issue, #9921:
URL: https://github.com/apache/arrow-rs/issues/9921
As an API suggestion (maybe for another PR, not required):
I would personally find this much easier to understand if the fields were named so I didn't have to refer to `make_int32_page_reader` to figure out what`&[0, 1, 2, 3, 1]` and `&[0, 1, 1, 1, 1]` meant.
Perhaps we could do this with an builder in the test. Something like this perhaps:
```rust
let array_reader_1 = TestArrayReaderBuilder::new()
.with_non_null_i32_values(&[4]) // <-- this is especially non obvous if you are used to normal Arrow arrays
.with_def_levels(&[0, 1, 2, 3, 1])
.with_rep_levels(&[0, 1, 1, 1, 1])
.with_max_def_level(3)
.with_max_rep_level(1)
.build()
```
_Originally posted by @alamb in https://github.com/apache/arrow-rs/pull/9847#discussion_r3173223954_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Improve parquet ArrayReaderBuilder tests [arrow-rs]
Posted by "aruadecarvalho (via GitHub)" <gi...@apache.org>.
aruadecarvalho commented on issue #9921:
URL: https://github.com/apache/arrow-rs/issues/9921#issuecomment-6270424459
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Improve parquet ArrayReaderBuilder tests [arrow-rs]
Posted by "krishnakeshan (via GitHub)" <gi...@apache.org>.
krishnakeshan commented on issue #9921:
URL: https://github.com/apache/arrow-rs/issues/9921#issuecomment-5975422068
#10500 looks stale, so can I pick this up in a new PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Improve parquet ArrayReaderBuilder tests [arrow-rs]
Posted by "tomatotomata (via GitHub)" <gi...@apache.org>.
tomatotomata commented on issue #9921:
URL: https://github.com/apache/arrow-rs/issues/9921#issuecomment-5139772947
I can take this focused test readability cleanup. I was thinking of introducing a small `TestArrayReaderBuilder` in the parquet test module so the definition and level vectors are named at the call site, then running the targeted parquet reader tests without changing production behavior. If that scope fits the issue, let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Improve parquet ArrayReaderBuilder tests [arrow-rs]
Posted by "aruadecarvalho (via GitHub)" <gi...@apache.org>.
aruadecarvalho commented on issue #9921:
URL: https://github.com/apache/arrow-rs/issues/9921#issuecomment-6268863238
Hi @krishnakeshan , did you end up picking this up? If not, I’d love to give it a try as my first contribution to Arrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Improve parquet ArrayReaderBuilder tests [arrow-rs]
Posted by "aruadecarvalho (via GitHub)" <gi...@apache.org>.
aruadecarvalho commented on issue #9921:
URL: https://github.com/apache/arrow-rs/issues/9921#issuecomment-6270945609
Hi @alamb , is this still something worth picking up? I saw #10500 was closed as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Improve parquet ArrayReaderBuilder tests [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #9921:
URL: https://github.com/apache/arrow-rs/issues/9921#issuecomment-5169633048
that seems like a good idea -- though it would be good to create the builder and then try to migrate one or two tests to keep the review manageable. Then we can migrate the rest of the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Improve parquet ArrayReaderBuilder tests [arrow-rs]
Posted by "krishnakeshan (via GitHub)" <gi...@apache.org>.
krishnakeshan commented on issue #9921:
URL: https://github.com/apache/arrow-rs/issues/9921#issuecomment-6270269908
Hi @aruadecarvalho no I did not pick this up. Feel free to take :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org