[GitHub] [airflow] eladkal commented on a diff in pull request #24038: Implement Azure Service Bus Queue Operator's

[GitBox <gi...@apache.org>]

eladkal commented on code in PR #24038:
URL: https://github.com/apache/airflow/pull/24038#discussion_r887583861


##########
airflow/providers/microsoft/azure/hooks/asb_admin_client.py:
##########
@@ -0,0 +1,83 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   I think we should have unified `hooks/asb.py` with classes `AdminClientHook`, `MessageHook`
   That is also how we do it for the other
   
   @josh-fell WDYT?



##########
airflow/providers/microsoft/azure/operators/azure_service_bus_queue.py:
##########
@@ -0,0 +1,182 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   Same concern. It should be just `operators/asb.py`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org