You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ko...@apache.org on 2017/02/21 10:12:44 UTC

svn commit: r1783862 - in /subversion/trunk/subversion: include/svn_hash.h libsvn_subr/hash.c

Author: kotkov
Date: Tue Feb 21 10:12:44 2017
New Revision: 1783862

URL: http://svn.apache.org/viewvc?rev=1783862&view=rev
Log:
Rename our debug helpers, svn_hash__gets() and svn_hash__sets() to make
them visually different from the svn_hash_gets() and svn_hash_sets()
macros.

These functions are only used in conjunction with SVN_DEBUG to gain
additional type safety, and should not be used by themselves in the
production code.

* subversion/include/svn_hash.h
  (svn_hash__gets, svn_hash__sets): Rename to ...
  (svn_hash__gets_debug, svn_hash__sets_debug): ...this.
  (svn_hash_gets, svn_hash_sets): Update these macros.

* subversion/libsvn_subr/hash.c
  (svn_hash__gets, svn_hash__sets): Rename to ...
  (svn_hash__gets_debug, svn_hash__sets_debug): ...this.

Modified:
    subversion/trunk/subversion/include/svn_hash.h
    subversion/trunk/subversion/libsvn_subr/hash.c

Modified: subversion/trunk/subversion/include/svn_hash.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_hash.h?rev=1783862&r1=1783861&r2=1783862&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_hash.h (original)
+++ subversion/trunk/subversion/include/svn_hash.h Tue Feb 21 10:12:44 2017
@@ -250,10 +250,10 @@ svn_hash_from_cstring_keys(apr_hash_t **
 
 #ifdef SVN_HASH__GETS_SETS
 void *
-svn_hash__gets(apr_hash_t *ht, const char *key);
+svn_hash__gets_debug(apr_hash_t *ht, const char *key);
 
 #define svn_hash_gets(ht, key) \
-            svn_hash__gets(ht, key)
+            svn_hash__gets_debug(ht, key)
 #else
 /** Shortcut for apr_hash_get() with a const char * key.
  *
@@ -265,10 +265,10 @@ svn_hash__gets(apr_hash_t *ht, const cha
 
 #ifdef SVN_HASH__GETS_SETS
 void
-svn_hash__sets(apr_hash_t *ht, const char *key, const void *value);
+svn_hash__sets_debug(apr_hash_t *ht, const char *key, const void *value);
 
 #define svn_hash_sets(ht, key, val) \
-            svn_hash__sets(ht, key, val)
+            svn_hash__sets_debug(ht, key, val)
 #else
 /** Shortcut for apr_hash_set() with a const char * key.
  *

Modified: subversion/trunk/subversion/libsvn_subr/hash.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/hash.c?rev=1783862&r1=1783861&r2=1783862&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/hash.c (original)
+++ subversion/trunk/subversion/libsvn_subr/hash.c Tue Feb 21 10:12:44 2017
@@ -564,14 +564,14 @@ svn_hash_from_cstring_keys(apr_hash_t **
 
 
 void *
-svn_hash__gets(apr_hash_t *ht, const char *key)
+svn_hash__gets_debug(apr_hash_t *ht, const char *key)
 {
   return apr_hash_get(ht, key, APR_HASH_KEY_STRING);
 }
 
 
 void
-svn_hash__sets(apr_hash_t *ht, const char *key, const void *val)
+svn_hash__sets_debug(apr_hash_t *ht, const char *key, const void *val)
 {
   apr_hash_set(ht, key, APR_HASH_KEY_STRING, val);
 }