You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/16 10:40:00 UTC
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest
options
[ https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439262#comment-16439262 ]
ASF GitHub Bot commented on FLINK-9180:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/5852
[FLINK-9180] [conf] Remove REST_ prefix from rest options
## What is the purpose of the change
Remove REST_ prefix from rest options
## Brief change log
Update ```RestOptions.java``` for removing prefix rest_
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-9180
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5852.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5852
----
commit 711474f663f41025b42e4abb4c35315b426aff57
Author: zhangminglei <zm...@...>
Date: 2018-04-16T10:36:30Z
[FLINK-9180] [conf] Remove REST_ prefix from rest options
----
> Remove REST_ prefix from rest options
> -------------------------------------
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: mingleizhang
> Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far we went with the convention that we do not have such prefixes if it already contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)