You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Joel Reymont (JIRA)" <ji...@apache.org> on 2011/03/18 15:59:29 UTC

[jira] Created: (THRIFT-1096) OCaml generated code does not compile

OCaml generated code does not compile
-------------------------------------

                 Key: THRIFT-1096
                 URL: https://issues.apache.org/jira/browse/THRIFT-1096
             Project: Thrift
          Issue Type: Bug
          Components: OCaml - Compiler
    Affects Versions: 0.5
         Environment: The Objective Caml toplevel, version 3.13.0+dev2 (2010-10-22)

            Reporter: Joel Reymont


What is generated:

open Thrift
class document :
object
  method get_username : string option
  method grab_username : string
  method set_username : string -> unit
  method unset_username : unit
  method reset_username : unit
  method get_docname : string option
  method grab_docname : string
  method set_docname : string -> unit
  method unset_docname : unit
  method reset_docname : unit
  method get_page : int option
  method grab_page : int
  method set_page : int -> unit
  method unset_page : unit
  method reset_page : unit
  method copy
  method write : Protocol.t -> unit
end
val read_document : Protocol.t -> document

What is needed (note the 'a in object and copy method).

open Thrift
class document :
object ('a)
  method get_username : string option
  method grab_username : string
  method set_username : string -> unit
  method unset_username : unit
  method reset_username : unit
  method get_docname : string option
  method grab_docname : string
  method set_docname : string -> unit
  method unset_docname : unit
  method reset_docname : unit
  method get_page : int option
  method grab_page : int
  method set_page : int -> unit
  method unset_page : unit
  method reset_page : unit
  method copy : 'a
  method write : Protocol.t -> unit
end
val read_document : Protocol.t -> document


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1096) OCaml generated code does not compile

Posted by "Joel Reymont (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joel Reymont closed THRIFT-1096.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.7

> OCaml generated code does not compile
> -------------------------------------
>
>                 Key: THRIFT-1096
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1096
>             Project: Thrift
>          Issue Type: Bug
>          Components: OCaml - Compiler
>    Affects Versions: 0.5
>         Environment: The Objective Caml toplevel, version 3.13.0+dev2 (2010-10-22)
>            Reporter: Joel Reymont
>             Fix For: 0.7
>
>
> What is generated:
> open Thrift
> class document :
> object
>   method get_username : string option
>   method grab_username : string
>   method set_username : string -> unit
>   method unset_username : unit
>   method reset_username : unit
>   method get_docname : string option
>   method grab_docname : string
>   method set_docname : string -> unit
>   method unset_docname : unit
>   method reset_docname : unit
>   method get_page : int option
>   method grab_page : int
>   method set_page : int -> unit
>   method unset_page : unit
>   method reset_page : unit
>   method copy
>   method write : Protocol.t -> unit
> end
> val read_document : Protocol.t -> document
> What is needed (note the 'a in object and copy method).
> open Thrift
> class document :
> object ('a)
>   method get_username : string option
>   method grab_username : string
>   method set_username : string -> unit
>   method unset_username : unit
>   method reset_username : unit
>   method get_docname : string option
>   method grab_docname : string
>   method set_docname : string -> unit
>   method unset_docname : unit
>   method reset_docname : unit
>   method get_page : int option
>   method grab_page : int
>   method set_page : int -> unit
>   method unset_page : unit
>   method reset_page : unit
>   method copy : 'a
>   method write : Protocol.t -> unit
> end
> val read_document : Protocol.t -> document

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (THRIFT-1096) OCaml generated code does not compile

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury reopened THRIFT-1096:
-----------------------------------


> OCaml generated code does not compile
> -------------------------------------
>
>                 Key: THRIFT-1096
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1096
>             Project: Thrift
>          Issue Type: Bug
>          Components: OCaml - Compiler
>    Affects Versions: 0.5
>         Environment: The Objective Caml toplevel, version 3.13.0+dev2 (2010-10-22)
>            Reporter: Joel Reymont
>
> What is generated:
> open Thrift
> class document :
> object
>   method get_username : string option
>   method grab_username : string
>   method set_username : string -> unit
>   method unset_username : unit
>   method reset_username : unit
>   method get_docname : string option
>   method grab_docname : string
>   method set_docname : string -> unit
>   method unset_docname : unit
>   method reset_docname : unit
>   method get_page : int option
>   method grab_page : int
>   method set_page : int -> unit
>   method unset_page : unit
>   method reset_page : unit
>   method copy
>   method write : Protocol.t -> unit
> end
> val read_document : Protocol.t -> document
> What is needed (note the 'a in object and copy method).
> open Thrift
> class document :
> object ('a)
>   method get_username : string option
>   method grab_username : string
>   method set_username : string -> unit
>   method unset_username : unit
>   method reset_username : unit
>   method get_docname : string option
>   method grab_docname : string
>   method set_docname : string -> unit
>   method unset_docname : unit
>   method reset_docname : unit
>   method get_page : int option
>   method grab_page : int
>   method set_page : int -> unit
>   method unset_page : unit
>   method reset_page : unit
>   method copy : 'a
>   method write : Protocol.t -> unit
> end
> val read_document : Protocol.t -> document

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1096) OCaml generated code does not compile

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-1096.
---------------------------------

       Resolution: Duplicate
    Fix Version/s:     (was: 0.7)

> OCaml generated code does not compile
> -------------------------------------
>
>                 Key: THRIFT-1096
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1096
>             Project: Thrift
>          Issue Type: Bug
>          Components: OCaml - Compiler
>    Affects Versions: 0.5
>         Environment: The Objective Caml toplevel, version 3.13.0+dev2 (2010-10-22)
>            Reporter: Joel Reymont
>
> What is generated:
> open Thrift
> class document :
> object
>   method get_username : string option
>   method grab_username : string
>   method set_username : string -> unit
>   method unset_username : unit
>   method reset_username : unit
>   method get_docname : string option
>   method grab_docname : string
>   method set_docname : string -> unit
>   method unset_docname : unit
>   method reset_docname : unit
>   method get_page : int option
>   method grab_page : int
>   method set_page : int -> unit
>   method unset_page : unit
>   method reset_page : unit
>   method copy
>   method write : Protocol.t -> unit
> end
> val read_document : Protocol.t -> document
> What is needed (note the 'a in object and copy method).
> open Thrift
> class document :
> object ('a)
>   method get_username : string option
>   method grab_username : string
>   method set_username : string -> unit
>   method unset_username : unit
>   method reset_username : unit
>   method get_docname : string option
>   method grab_docname : string
>   method set_docname : string -> unit
>   method unset_docname : unit
>   method reset_docname : unit
>   method get_page : int option
>   method grab_page : int
>   method set_page : int -> unit
>   method unset_page : unit
>   method reset_page : unit
>   method copy : 'a
>   method write : Protocol.t -> unit
> end
> val read_document : Protocol.t -> document

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1096) OCaml generated code does not compile

Posted by "Joel Reymont (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009744#comment-13009744 ] 

Joel Reymont commented on THRIFT-1096:
--------------------------------------

I saw it fixed in HEAD.

> OCaml generated code does not compile
> -------------------------------------
>
>                 Key: THRIFT-1096
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1096
>             Project: Thrift
>          Issue Type: Bug
>          Components: OCaml - Compiler
>    Affects Versions: 0.5
>         Environment: The Objective Caml toplevel, version 3.13.0+dev2 (2010-10-22)
>            Reporter: Joel Reymont
>             Fix For: 0.7
>
>
> What is generated:
> open Thrift
> class document :
> object
>   method get_username : string option
>   method grab_username : string
>   method set_username : string -> unit
>   method unset_username : unit
>   method reset_username : unit
>   method get_docname : string option
>   method grab_docname : string
>   method set_docname : string -> unit
>   method unset_docname : unit
>   method reset_docname : unit
>   method get_page : int option
>   method grab_page : int
>   method set_page : int -> unit
>   method unset_page : unit
>   method reset_page : unit
>   method copy
>   method write : Protocol.t -> unit
> end
> val read_document : Protocol.t -> document
> What is needed (note the 'a in object and copy method).
> open Thrift
> class document :
> object ('a)
>   method get_username : string option
>   method grab_username : string
>   method set_username : string -> unit
>   method unset_username : unit
>   method reset_username : unit
>   method get_docname : string option
>   method grab_docname : string
>   method set_docname : string -> unit
>   method unset_docname : unit
>   method reset_docname : unit
>   method get_page : int option
>   method grab_page : int
>   method set_page : int -> unit
>   method unset_page : unit
>   method reset_page : unit
>   method copy : 'a
>   method write : Protocol.t -> unit
> end
> val read_document : Protocol.t -> document

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (THRIFT-1096) OCaml generated code does not compile

Posted by "Joel Reymont (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008462#comment-13008462 ] 

Joel Reymont commented on THRIFT-1096:
--------------------------------------

Relevant errors:

https://gist.github.com/876154

> OCaml generated code does not compile
> -------------------------------------
>
>                 Key: THRIFT-1096
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1096
>             Project: Thrift
>          Issue Type: Bug
>          Components: OCaml - Compiler
>    Affects Versions: 0.5
>         Environment: The Objective Caml toplevel, version 3.13.0+dev2 (2010-10-22)
>            Reporter: Joel Reymont
>
> What is generated:
> open Thrift
> class document :
> object
>   method get_username : string option
>   method grab_username : string
>   method set_username : string -> unit
>   method unset_username : unit
>   method reset_username : unit
>   method get_docname : string option
>   method grab_docname : string
>   method set_docname : string -> unit
>   method unset_docname : unit
>   method reset_docname : unit
>   method get_page : int option
>   method grab_page : int
>   method set_page : int -> unit
>   method unset_page : unit
>   method reset_page : unit
>   method copy
>   method write : Protocol.t -> unit
> end
> val read_document : Protocol.t -> document
> What is needed (note the 'a in object and copy method).
> open Thrift
> class document :
> object ('a)
>   method get_username : string option
>   method grab_username : string
>   method set_username : string -> unit
>   method unset_username : unit
>   method reset_username : unit
>   method get_docname : string option
>   method grab_docname : string
>   method set_docname : string -> unit
>   method unset_docname : unit
>   method reset_docname : unit
>   method get_page : int option
>   method grab_page : int
>   method set_page : int -> unit
>   method unset_page : unit
>   method reset_page : unit
>   method copy : 'a
>   method write : Protocol.t -> unit
> end
> val read_document : Protocol.t -> document

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1096) OCaml generated code does not compile

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009743#comment-13009743 ] 

Bryan Duxbury commented on THRIFT-1096:
---------------------------------------

Joel - why did you close this ticket? I didn't see any patch or commits.

> OCaml generated code does not compile
> -------------------------------------
>
>                 Key: THRIFT-1096
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1096
>             Project: Thrift
>          Issue Type: Bug
>          Components: OCaml - Compiler
>    Affects Versions: 0.5
>         Environment: The Objective Caml toplevel, version 3.13.0+dev2 (2010-10-22)
>            Reporter: Joel Reymont
>             Fix For: 0.7
>
>
> What is generated:
> open Thrift
> class document :
> object
>   method get_username : string option
>   method grab_username : string
>   method set_username : string -> unit
>   method unset_username : unit
>   method reset_username : unit
>   method get_docname : string option
>   method grab_docname : string
>   method set_docname : string -> unit
>   method unset_docname : unit
>   method reset_docname : unit
>   method get_page : int option
>   method grab_page : int
>   method set_page : int -> unit
>   method unset_page : unit
>   method reset_page : unit
>   method copy
>   method write : Protocol.t -> unit
> end
> val read_document : Protocol.t -> document
> What is needed (note the 'a in object and copy method).
> open Thrift
> class document :
> object ('a)
>   method get_username : string option
>   method grab_username : string
>   method set_username : string -> unit
>   method unset_username : unit
>   method reset_username : unit
>   method get_docname : string option
>   method grab_docname : string
>   method set_docname : string -> unit
>   method unset_docname : unit
>   method reset_docname : unit
>   method get_page : int option
>   method grab_page : int
>   method set_page : int -> unit
>   method unset_page : unit
>   method reset_page : unit
>   method copy : 'a
>   method write : Protocol.t -> unit
> end
> val read_document : Protocol.t -> document

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira