You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mahout.apache.org by ss...@apache.org on 2013/06/01 18:08:26 UTC
svn commit: r1488540 - in /mahout/trunk: CHANGELOG core/src/main/java/org/apache/mahout/cf/taste/hadoop/als/ParallelALSFactorizationJob.java

Author: ssc
Date: Sat Jun  1 16:08:26 2013
New Revision: 1488540

URL: http://svn.apache.org/r1488540
Log:
MAHOUT 1235: ParallelALSFactorizationJob does not use VectorSumCombiner

Modified:
    mahout/trunk/CHANGELOG
    mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/als/ParallelALSFactorizationJob.java

Modified: mahout/trunk/CHANGELOG
URL: http://svn.apache.org/viewvc/mahout/trunk/CHANGELOG?rev=1488540&r1=1488539&r2=1488540&view=diff
==============================================================================
--- mahout/trunk/CHANGELOG (original)
+++ mahout/trunk/CHANGELOG Sat Jun  1 16:08:26 2013
@@ -2,6 +2,8 @@ Mahout Change Log
 
 Release 0.8 - unreleased
 
+  MAHOUT-1235: ParallelALSFactorizationJob does not use VectorSumCombiner (ssc)
+
   MAHOUT-1230: SparceMatrix.clone() is not deep copy (Maysam Yabandeh via tdunning)
   
   MAHOUT-1232: VectorHelper.topEntries() throws a NPE when number of NonZero elements in vector < maxEntries (smarthi)

Modified: mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/als/ParallelALSFactorizationJob.java
URL: http://svn.apache.org/viewvc/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/als/ParallelALSFactorizationJob.java?rev=1488540&r1=1488539&r2=1488540&view=diff
==============================================================================
--- mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/als/ParallelALSFactorizationJob.java (original)
+++ mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/als/ParallelALSFactorizationJob.java Sat Jun  1 16:08:26 2013
@@ -142,7 +142,7 @@ public class ParallelALSFactorizationJob
         TextInputFormat.class, ItemRatingVectorsMapper.class, IntWritable.class,
         VectorWritable.class, VectorSumReducer.class, IntWritable.class,
         VectorWritable.class, SequenceFileOutputFormat.class);
-    itemRatings.setCombinerClass(VectorSumReducer.class);
+    itemRatings.setCombinerClass(VectorSumCombiner.class);
     boolean succeeded = itemRatings.waitForCompletion(true);
     if (!succeeded) {
       return -1;
@@ -298,11 +298,11 @@ public class ParallelALSFactorizationJob
 
     if (implicitFeedback) {
       solverMapperClassInternal = SolveImplicitFeedbackMapper.class;
-      name = "Recompute " + matrixName + ", iteration (" + iterationNumber + "/" + numIterations + "), "
+      name = "Recompute " + matrixName + ", iteration (" + (iterationNumber + 1) + "/" + numIterations + "), "
           + "(" + numThreadsPerSolver + " threads, " + numFeatures +" features, implicit feedback)";
     } else {
       solverMapperClassInternal = SolveExplicitFeedbackMapper.class;
-      name = "Recompute " + matrixName + ", iteration (" + iterationNumber + "/" + numIterations + "), "
+      name = "Recompute " + matrixName + ", iteration (" + (iterationNumber + 1) + "/" + numIterations + "), "
           + "(" + numThreadsPerSolver + " threads, " + numFeatures + " features, explicit feedback)";
     }