[GitHub] [drill] vvysotskyi commented on a change in pull request #2202: DRILL-7904: Update to 30-jre Guava version

[GitBox <gi...@apache.org>]

vvysotskyi commented on a change in pull request #2202:
URL: https://github.com/apache/drill/pull/2202#discussion_r619710872



##########
File path: distribution/src/assemble/component.xml
##########
@@ -90,9 +90,6 @@
       <outputDirectory>jars</outputDirectory>
       <unpack>false</unpack>
       <useProjectArtifact>false</useProjectArtifact>
-      <includes>
-        <include>org.apache.drill:drill-shaded-guava:jar</include>
-      </includes>
     </dependencySet>
 
     <dependencySet>

Review comment:
       Please remove the whole `dependencySet` block, since it is not needed without `includes`.

##########
File path: pom.xml
##########
@@ -1047,8 +1046,9 @@
     </dependency>
 
     <dependency>
-      <groupId>org.apache.drill</groupId>
-      <artifactId>drill-shaded-guava</artifactId>
+      <groupId>com.google.guava</groupId>
+      <artifactId>guava</artifactId>
+      <version>${guava.version}</version>

Review comment:
       Please remove the `version` line, version should be obtained from the dependencies management block.

##########
File path: docs/dev/ArtidfactsPublishing.md
##########
@@ -1,22 +1,8 @@
-# How to upgrade Guava in Drill

Review comment:
       Please remove whole the file, since except for shaded guava, there is no need anymore for publishing libraries manual.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org