You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by fj...@apache.org on 2019/04/09 15:40:16 UTC
[incubator-druid] branch master updated: Fix comments in
KinesisIndexTaskIOConfig (#7430)
This is an automated email from the ASF dual-hosted git repository.
fjy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new 09abc4a Fix comments in KinesisIndexTaskIOConfig (#7430)
09abc4a is described below
commit 09abc4a856e703c496c2c9fdb50f311db6a15626
Author: Jonathan Wei <jo...@users.noreply.github.com>
AuthorDate: Tue Apr 9 08:40:08 2019 -0700
Fix comments in KinesisIndexTaskIOConfig (#7430)
---
.../apache/druid/indexing/kinesis/KinesisIndexTaskIOConfig.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisIndexTaskIOConfig.java b/extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisIndexTaskIOConfig.java
index e726ae2..2967ef6 100644
--- a/extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisIndexTaskIOConfig.java
+++ b/extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisIndexTaskIOConfig.java
@@ -155,15 +155,17 @@ public class KinesisIndexTaskIOConfig extends SeekableStreamIndexTaskIOConfig<St
}
/**
- * This method is for compatibilty so that newer version of KafkaIndexTaskIOConfig can be read by
+ * This method is for compatibilty so that newer version of KinesisIndexTaskIOConfig can be read by
* old version of Druid. Note that this method returns end sequence numbers instead of start. This is because
* {@link SeekableStreamStartSequenceNumbers} didn't exist before.
+ *
+ * A SeekableStreamEndSequenceNumbers (has no exclusivity info) is returned here because the Kinesis extension
+ * previously stored exclusivity info separately in exclusiveStartSequenceNumberPartitions.
*/
@JsonProperty
@Deprecated
public SeekableStreamEndSequenceNumbers<String, String> getStartPartitions()
{
- // Converting to start sequence numbers. This is allowed for Kafka because the start offset is always inclusive.
final SeekableStreamStartSequenceNumbers<String, String> startSequenceNumbers = getStartSequenceNumbers();
return new SeekableStreamEndSequenceNumbers<>(
startSequenceNumbers.getStream(),
@@ -172,7 +174,7 @@ public class KinesisIndexTaskIOConfig extends SeekableStreamIndexTaskIOConfig<St
}
/**
- * This method is for compatibilty so that newer version of KafkaIndexTaskIOConfig can be read by
+ * This method is for compatibilty so that newer version of KinesisIndexTaskIOConfig can be read by
* old version of Druid.
*/
@JsonProperty
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org