You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/11 10:00:00 UTC
[GitHub] [flink] SteNicholas opened a new pull request #12078: [FLINK-17610]Align the behavior of result of internal map state to re…
SteNicholas opened a new pull request #12078:
URL: https://github.com/apache/flink/pull/12078
## What is the purpose of the change
*There are different behaviors of result of internal map state. For `HeapMapState`, #entries(), #keys(), #values(), and #iterator() would all return null. However, for `RocksDBMapState`, #entries() would return null, while #keys(), #values(), #iterator() would return empty iterator. UserFacingMapState would align behaviors to empty iterator instead of null.*
## Brief change log
- *Modify result of `HeapMapState` #entries(), #keys(), #values(), and #iterator() method to empty iterator.*
- *Modify result of `RocksDBMapState` #entries() method to empty iterator.*
## Verifying this change
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #12078: [FLINK-17610][state]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-629061686
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-632400538
@Myasuka Sorry for merge mistake. Please check the `isOriginalEmptyValue()` change for `TtlMapStateAllEntriesTestContext`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
}, {
"hash" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"triggerType" : "PUSH"
}, {
"hash" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998",
"triggerID" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"triggerType" : "PUSH"
}, {
"hash" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2020",
"triggerID" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"triggerType" : "PUSH"
}, {
"hash" : "1142276931ccfd3ab42da2f44369e649c911aafc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2027",
"triggerID" : "1142276931ccfd3ab42da2f44369e649c911aafc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3ffb15cc38bdbbf1f5a11014782d081edaecea6 UNKNOWN
* 1142276931ccfd3ab42da2f44369e649c911aafc Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2027)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4231cd63aa9c20769e3734b690347201f916541 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
}, {
"hash" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"triggerType" : "PUSH"
}, {
"hash" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998",
"triggerID" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"triggerType" : "PUSH"
}, {
"hash" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2020",
"triggerID" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"triggerType" : "PUSH"
}, {
"hash" : "1142276931ccfd3ab42da2f44369e649c911aafc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2027",
"triggerID" : "1142276931ccfd3ab42da2f44369e649c911aafc",
"triggerType" : "PUSH"
}, {
"hash" : "55be45331331ec6f336d3872b8616b899d936730",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "55be45331331ec6f336d3872b8616b899d936730",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3ffb15cc38bdbbf1f5a11014782d081edaecea6 UNKNOWN
* 1142276931ccfd3ab42da2f44369e649c911aafc Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2027)
* 55be45331331ec6f336d3872b8616b899d936730 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #12078: [FLINK-17610][state]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-629075752
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12078: [FLINK-17610]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c390fd024a6860c90160bf18599384bcc151f798 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
}, {
"hash" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"triggerType" : "PUSH"
}, {
"hash" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998",
"triggerID" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"triggerType" : "PUSH"
}, {
"hash" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2020",
"triggerID" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"triggerType" : "PUSH"
}, {
"hash" : "1142276931ccfd3ab42da2f44369e649c911aafc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2027",
"triggerID" : "1142276931ccfd3ab42da2f44369e649c911aafc",
"triggerType" : "PUSH"
}, {
"hash" : "55be45331331ec6f336d3872b8616b899d936730",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2120",
"triggerID" : "55be45331331ec6f336d3872b8616b899d936730",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3ffb15cc38bdbbf1f5a11014782d081edaecea6 UNKNOWN
* 55be45331331ec6f336d3872b8616b899d936730 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2120)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a78d906c62fc4c6149fa26f0fac3c12cac2267b6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144)
* a062967a2f5ecf77a7021d2bf5baffc229cbffc2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
}, {
"hash" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"triggerType" : "PUSH"
}, {
"hash" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998",
"triggerID" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3ffb15cc38bdbbf1f5a11014782d081edaecea6 UNKNOWN
* 15aed4e77715ccfd4588c2a740b91fc1467c629a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas removed a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-632082769
@Myasuka @klion26 @carp84 Please review the changes again, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
}, {
"hash" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"triggerType" : "PUSH"
}, {
"hash" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998",
"triggerID" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"triggerType" : "PUSH"
}, {
"hash" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2020",
"triggerID" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3ffb15cc38bdbbf1f5a11014782d081edaecea6 UNKNOWN
* d9fd98ae5664303184273f83e4afb0623e6406f0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2020)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas removed a comment on pull request #12078: [FLINK-17610][state]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-629075752
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a78d906c62fc4c6149fa26f0fac3c12cac2267b6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144)
* a062967a2f5ecf77a7021d2bf5baffc229cbffc2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389)
* c4231cd63aa9c20769e3734b690347201f916541 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a062967a2f5ecf77a7021d2bf5baffc229cbffc2 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389)
* c4231cd63aa9c20769e3734b690347201f916541 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #12078: [FLINK-17610][state]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #12078:
URL: https://github.com/apache/flink/pull/12078#discussion_r425817891
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/TtlMapStateAllEntriesTestContext.java
##########
@@ -64,6 +64,6 @@ public void update(Map<Integer, String> map) throws Exception {
@Override
public Object getOriginal() throws Exception {
- return ttlState.original.entries() == null ? Collections.emptySet() : ttlState.original.entries();
+ return ttlState.original.entries().iterator().hasNext() ? ttlState.original.entries() : emptyValue;
Review comment:
I think this implementation should already violate the purpose of unit test.
This method should return the **actual** value and then verify whether the result equals to the **expected** value. However, you just return the `emptyValue` which is the actual **expected** value, and the verification will always return true.
I think one of the walk-around solution is to add a method `boolean isOriginalEmptyValue(Object originalValue)` in `TtlStateTestContextBase`, which will return whether the original value equals to the `emptyValue`. By doing so, you could override this method in `TtlMapStateAllEntriesTestContext` and return whether the original value is actually an empty iterable.
Thus, we could replace `assertEquals("Expired original state should be unavailable", ctx().emptyValue, ctx().getOriginal());` to `assertTrue(ctx().isOriginalEmptyValue(ctx().getOriginal()));`
Any other better test solution is also welcome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
}, {
"hash" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"triggerType" : "PUSH"
}, {
"hash" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998",
"triggerID" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4231cd63aa9c20769e3734b690347201f916541 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395)
* e3ffb15cc38bdbbf1f5a11014782d081edaecea6 UNKNOWN
* 15aed4e77715ccfd4588c2a740b91fc1467c629a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
}, {
"hash" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"triggerType" : "PUSH"
}, {
"hash" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4231cd63aa9c20769e3734b690347201f916541 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395)
* e3ffb15cc38bdbbf1f5a11014782d081edaecea6 UNKNOWN
* 15aed4e77715ccfd4588c2a740b91fc1467c629a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
}, {
"hash" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"triggerType" : "PUSH"
}, {
"hash" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998",
"triggerID" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"triggerType" : "PUSH"
}, {
"hash" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2020",
"triggerID" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"triggerType" : "PUSH"
}, {
"hash" : "1142276931ccfd3ab42da2f44369e649c911aafc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1142276931ccfd3ab42da2f44369e649c911aafc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3ffb15cc38bdbbf1f5a11014782d081edaecea6 UNKNOWN
* d9fd98ae5664303184273f83e4afb0623e6406f0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2020)
* 1142276931ccfd3ab42da2f44369e649c911aafc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
klion26 commented on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-632548526
The latest change LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #12078:
URL: https://github.com/apache/flink/pull/12078#discussion_r428672149
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/TtlMapStateAllEntriesTestContext.java
##########
@@ -66,4 +67,9 @@ public void update(Map<Integer, String> map) throws Exception {
public Object getOriginal() throws Exception {
return ttlState.original.entries() == null ? Collections.emptySet() : ttlState.original.entries();
}
+
+ @Override
+ public boolean isOriginalEmptyValue() throws Exception {
+ return !Sets.newHashSet(getOriginal()).equals(emptyValue);
Review comment:
Just wonder if this method check whether original state is empty value, why we still need to return the opposite value? In other words, shall we just return `Objects.equals(emptyValue, Sets.newHashSet(getOriginal()))`?
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/collect/CollectSinkFunction.java
##########
@@ -229,7 +229,7 @@ public void open(Configuration parameters) throws Exception {
// so that the client can know if the sink has been restarted
version = UUID.randomUUID().toString();
- serverThread = new ServerThread();
+ serverThread = new ServerThread(serializer);
Review comment:
Why we need to include this change?
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/TtlStateTestContextBase.java
##########
@@ -46,6 +46,10 @@
public abstract Object getOriginal() throws Exception;
+ public boolean isOriginalEmptyValue() throws Exception {
+ return getOriginal() == emptyValue || getOriginal().equals(emptyValue);
Review comment:
Why not just `Objects.equals(emptyValue, getOriginal())` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-632452729
@Myasuka I have already align the test between `emptyValue` and `ctx().getOriginal()`, and run `TtlStateTestBase` all test case passed. Therefore, very thanks to review again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
}, {
"hash" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"triggerType" : "PUSH"
}, {
"hash" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998",
"triggerID" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"triggerType" : "PUSH"
}, {
"hash" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2020",
"triggerID" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"triggerType" : "PUSH"
}, {
"hash" : "1142276931ccfd3ab42da2f44369e649c911aafc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2027",
"triggerID" : "1142276931ccfd3ab42da2f44369e649c911aafc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3ffb15cc38bdbbf1f5a11014782d081edaecea6 UNKNOWN
* d9fd98ae5664303184273f83e4afb0623e6406f0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2020)
* 1142276931ccfd3ab42da2f44369e649c911aafc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2027)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas removed a comment on pull request #12078: [FLINK-17610][state]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-627770828
@Myasuka Please check again the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c390fd024a6860c90160bf18599384bcc151f798 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-632400538
@Myasuka Sorry for squash mistake. Please check the `isOriginalEmptyValue()` change for `TtlMapStateAllEntriesTestContext`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas removed a comment on pull request #12078: [FLINK-17610][state]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-629061686
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-632455461
@SteNicholas Thanks for your update. Let's wait for a green build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
}, {
"hash" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"triggerType" : "PUSH"
}, {
"hash" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998",
"triggerID" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"triggerType" : "PUSH"
}, {
"hash" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2020",
"triggerID" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"triggerType" : "PUSH"
}, {
"hash" : "1142276931ccfd3ab42da2f44369e649c911aafc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2027",
"triggerID" : "1142276931ccfd3ab42da2f44369e649c911aafc",
"triggerType" : "PUSH"
}, {
"hash" : "55be45331331ec6f336d3872b8616b899d936730",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2120",
"triggerID" : "55be45331331ec6f336d3872b8616b899d936730",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3ffb15cc38bdbbf1f5a11014782d081edaecea6 UNKNOWN
* 1142276931ccfd3ab42da2f44369e649c911aafc Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2027)
* 55be45331331ec6f336d3872b8616b899d936730 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2120)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a78d906c62fc4c6149fa26f0fac3c12cac2267b6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144)
* a062967a2f5ecf77a7021d2bf5baffc229cbffc2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-633342039
@carp84 Please help to review if you are free.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
}, {
"hash" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"triggerType" : "PUSH"
}, {
"hash" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998",
"triggerID" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"triggerType" : "PUSH"
}, {
"hash" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2020",
"triggerID" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"triggerType" : "PUSH"
}, {
"hash" : "1142276931ccfd3ab42da2f44369e649c911aafc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2027",
"triggerID" : "1142276931ccfd3ab42da2f44369e649c911aafc",
"triggerType" : "PUSH"
}, {
"hash" : "55be45331331ec6f336d3872b8616b899d936730",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2120",
"triggerID" : "55be45331331ec6f336d3872b8616b899d936730",
"triggerType" : "PUSH"
}, {
"hash" : "c87fc3764b52f86b03ee7f0381271c4240671ca1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c87fc3764b52f86b03ee7f0381271c4240671ca1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3ffb15cc38bdbbf1f5a11014782d081edaecea6 UNKNOWN
* 55be45331331ec6f336d3872b8616b899d936730 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2120)
* c87fc3764b52f86b03ee7f0381271c4240671ca1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-632082769
@Myasuka @klion26 @carp84 Please review the changes again, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #12078:
URL: https://github.com/apache/flink/pull/12078#discussion_r429010509
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/ttl/RocksDBTtlStateTestBase.java
##########
@@ -41,6 +41,7 @@
import static org.apache.flink.contrib.streaming.state.RocksDBOptions.TTL_COMPACT_FILTER_ENABLED;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotEquals;
+import static org.junit.Assert.assertTrue;
/** Base test suite for rocksdb state TTL. */
public abstract class RocksDBTtlStateTestBase extends TtlStateTestBase {
Review comment:
I noticed the [CI](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=2020&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=4ed44b66-cdd6-5dcf-5f6a-88b07dda665d) still broken.
There existed three `assertEquals("Original state should be cleared on access", ctx().emptyValue, ctx().getOriginal());` in `TtlStateTestBase.java` and I think they are both effected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-633568565
@carp84 I have merged the latest master code and resolved conflicts. Please help to check again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a78d906c62fc4c6149fa26f0fac3c12cac2267b6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144)
* a062967a2f5ecf77a7021d2bf5baffc229cbffc2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389)
* c4231cd63aa9c20769e3734b690347201f916541 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 commented on a change in pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
carp84 commented on a change in pull request #12078:
URL: https://github.com/apache/flink/pull/12078#discussion_r429752787
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/TtlStateTestBase.java
##########
@@ -208,7 +209,7 @@ public void testExactExpirationOnWrite() throws Exception {
timeProvider.time = 300;
assertEquals(EXPIRED_UNAVAIL, ctx().emptyValue, ctx().get());
- assertEquals("Original state should be cleared on access", ctx().emptyValue, ctx().getOriginal());
+ assertTrue(ctx().isOriginalEmptyValue());
Review comment:
```suggestion
assertTrue("Original state should be cleared on access", ctx().isOriginalEmptyValue());
```
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/ttl/RocksDBTtlStateTestBase.java
##########
@@ -161,11 +162,11 @@ private void testCompactFilter(boolean takeSnapshot, boolean rescaleAfterRestore
setTimeAndCompact(stateDesc, 170L);
sbetc.setCurrentKey("k1");
- assertEquals("Expired original state should be unavailable", ctx().emptyValue, ctx().getOriginal());
+ assertTrue(ctx().isOriginalEmptyValue());
Review comment:
```suggestion
assertTrue("Expired original state should be unavailable", ctx().isOriginalEmptyValue());
```
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/TtlStateTestBase.java
##########
@@ -222,7 +223,7 @@ public void testRelaxedExpirationOnWrite() throws Exception {
timeProvider.time = 120;
assertEquals(EXPIRED_AVAIL, ctx().getUpdateEmpty, ctx().get());
- assertEquals("Original state should be cleared on access", ctx().emptyValue, ctx().getOriginal());
+ assertTrue(ctx().isOriginalEmptyValue());
Review comment:
```suggestion
assertTrue("Original state should be cleared on access", ctx().isOriginalEmptyValue());
```
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/TtlStateTestBase.java
##########
@@ -247,7 +248,7 @@ public void testExactExpirationOnRead() throws Exception {
timeProvider.time = 250;
assertEquals(EXPIRED_UNAVAIL, ctx().emptyValue, ctx().get());
- assertEquals("Original state should be cleared on access", ctx().emptyValue, ctx().getOriginal());
+ assertTrue(ctx().isOriginalEmptyValue());
Review comment:
```suggestion
assertTrue("Original state should be cleared on access", ctx().isOriginalEmptyValue());
```
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/TtlStateTestBase.java
##########
@@ -509,7 +510,7 @@ public void testIncrementalCleanup() throws Exception {
private void checkExpiredKeys(int startKey, int endKey) throws Exception {
for (int i = startKey; i < endKey; i++) {
sbetc.setCurrentKey(Integer.toString(i));
- assertEquals("Original state should be cleared", ctx().emptyValue, ctx().getOriginal());
+ assertTrue(ctx().isOriginalEmptyValue());
Review comment:
```suggestion
assertTrue("Original state should be cleared", ctx().isOriginalEmptyValue());
```
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/ttl/RocksDBTtlStateTestBase.java
##########
@@ -161,11 +162,11 @@ private void testCompactFilter(boolean takeSnapshot, boolean rescaleAfterRestore
setTimeAndCompact(stateDesc, 170L);
sbetc.setCurrentKey("k1");
- assertEquals("Expired original state should be unavailable", ctx().emptyValue, ctx().getOriginal());
+ assertTrue(ctx().isOriginalEmptyValue());
assertEquals(EXPIRED_UNAVAIL, ctx().emptyValue, ctx().get());
sbetc.setCurrentKey("k2");
- assertEquals("Expired original state should be unavailable", ctx().emptyValue, ctx().getOriginal());
+ assertTrue(ctx().isOriginalEmptyValue());
Review comment:
```suggestion
assertTrue("Expired original state should be unavailable", ctx().isOriginalEmptyValue());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12078: [FLINK-17610]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626605997
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c390fd024a6860c90160bf18599384bcc151f798 (Mon May 11 10:06:06 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17610).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
klion26 edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-632548526
@SteNicholas thanks for your update, the latest change LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 commented on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
carp84 commented on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-633404190
Please also rebase on the latest code base to resolve conflicts. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
}, {
"hash" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4231cd63aa9c20769e3734b690347201f916541 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395)
* e3ffb15cc38bdbbf1f5a11014782d081edaecea6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c390fd024a6860c90160bf18599384bcc151f798 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
}, {
"hash" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"triggerType" : "PUSH"
}, {
"hash" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998",
"triggerID" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"triggerType" : "PUSH"
}, {
"hash" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2020",
"triggerID" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3ffb15cc38bdbbf1f5a11014782d081edaecea6 UNKNOWN
* 15aed4e77715ccfd4588c2a740b91fc1467c629a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998)
* d9fd98ae5664303184273f83e4afb0623e6406f0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2020)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12078: [FLINK-17610][state] Align the behavior of result of internal map state to return empty iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12078:
URL: https://github.com/apache/flink/pull/12078#issuecomment-626611802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c390fd024a6860c90160bf18599384bcc151f798",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=979",
"triggerID" : "c390fd024a6860c90160bf18599384bcc151f798",
"triggerType" : "PUSH"
}, {
"hash" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1024",
"triggerID" : "5b5afa9adf5e4ce9c2ac7924887469ae2ddd3bfb",
"triggerType" : "PUSH"
}, {
"hash" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1053",
"triggerID" : "d4407c0889673ba0307dc2b602ae49977a5520ea",
"triggerType" : "PUSH"
}, {
"hash" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1095",
"triggerID" : "499bcf1da9dd6fd866fc12323ad16e0c5d76fcfd",
"triggerType" : "PUSH"
}, {
"hash" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1144",
"triggerID" : "a78d906c62fc4c6149fa26f0fac3c12cac2267b6",
"triggerType" : "PUSH"
}, {
"hash" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1389",
"triggerID" : "a062967a2f5ecf77a7021d2bf5baffc229cbffc2",
"triggerType" : "PUSH"
}, {
"hash" : "c4231cd63aa9c20769e3734b690347201f916541",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1395",
"triggerID" : "c4231cd63aa9c20769e3734b690347201f916541",
"triggerType" : "PUSH"
}, {
"hash" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ffb15cc38bdbbf1f5a11014782d081edaecea6",
"triggerType" : "PUSH"
}, {
"hash" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998",
"triggerID" : "15aed4e77715ccfd4588c2a740b91fc1467c629a",
"triggerType" : "PUSH"
}, {
"hash" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d9fd98ae5664303184273f83e4afb0623e6406f0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3ffb15cc38bdbbf1f5a11014782d081edaecea6 UNKNOWN
* 15aed4e77715ccfd4588c2a740b91fc1467c629a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1998)
* d9fd98ae5664303184273f83e4afb0623e6406f0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on a change in pull request #12078: [FLINK-17610][state]Align the behavior of result of internal map state to re…
Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #12078:
URL: https://github.com/apache/flink/pull/12078#discussion_r427116721
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBMapState.java
##########
@@ -227,6 +220,7 @@ public void migrateSerializedValue(
}
}
+ @Nonnull
Review comment:
As the [code stye](https://flink.apache.org/contributing/code-style-and-quality-common.html#nullability-of-the-mutable-parts) said , we can get rid of the annotation.
```
Note: This means that @Nonnull annotations are usually not necessary, but can be used in certain cases to override a previous annotation, or to point non-nullability out in a context where one would expect a nullable value.
```
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
##########
@@ -2875,7 +2875,8 @@ public void testMapStateDefaultValue() throws Exception {
VoidNamespaceSerializer.INSTANCE, kvId);
backend.setCurrentKey(1);
- assertNull(state.entries());
+ assertNotNull(state.entries());
Review comment:
maybe we need to verify the result of `entries` is what we want.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapMapState.java
##########
@@ -140,25 +141,25 @@ public boolean contains(UK userKey) {
@Override
public Iterable<Map.Entry<UK, UV>> entries() {
Map<UK, UV> userMap = stateTable.get(currentNamespace);
- return userMap == null ? null : userMap.entrySet();
+ return userMap == null ? Collections.emptyList() : userMap.entrySet();
Review comment:
Do we need to return `Collections.emptySet` here to align with the `userMap.entrySet()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org