[GitHub] [iceberg] dungdm93 commented on a change in pull request #4264: Flink: Refactor to use the BaseEqualityDeltaWriter.

[GitBox <gi...@apache.org>]

dungdm93 commented on a change in pull request #4264:
URL: https://github.com/apache/iceberg/pull/4264#discussion_r819238913



##########
File path: core/src/main/java/org/apache/iceberg/deletes/EqualityDeleteWriter.java
##########
@@ -43,6 +43,7 @@
   private final int[] equalityFieldIds;
   private final SortOrder sortOrder;
   private DeleteFile deleteFile = null;
+  private long rowOffset = 0;

Review comment:
       How about name `recordCount` or `rowCount`?
   `rowOffset` is specific for tracking record write to file, `recordCount` is more general.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org