You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jerryshao <gi...@git.apache.org> on 2017/06/06 13:02:32 UTC

[GitHub] spark pull request #17882: [SPARK-20079][try 2][yarn] Re registration of AM ...

Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17882#discussion_r120351695
  
    --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala ---
    @@ -68,6 +68,8 @@ private[spark] abstract class YarnSchedulerBackend(
       // Flag to specify whether this schedulerBackend should be reset.
       private var shouldResetOnAmRegister = false
     
    +  private var lastRequestExecutors = RequestExecutors(-1, -1, Map.empty, Set.empty)
    --- End diff --
    
    I would suggest to change the first `-1` to `Utils#getDynamicAllocationInitialExecutors`, and the second to be "0".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org