You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/02/22 22:05:36 UTC
[kudu-CR] KUDU-2291 (part 7): fix race in stack trace collection
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9406
Change subject: KUDU-2291 (part 7): fix race in stack trace collection
......................................................................
KUDU-2291 (part 7): fix race in stack trace collection
This fixes a narrow race in which StackTraceCollector could return
'TimedOut' but in fact the stack trace would have been collected.
See the comments for details.
Change-Id: Id1af0ffa02efb8151f1f3f84dd142d91066cc1f8
---
M src/kudu/util/debug-util.cc
M src/kudu/util/debug-util.h
2 files changed, 19 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/9406/1
--
To view, visit http://gerrit.cloudera.org:8080/9406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1af0ffa02efb8151f1f3f84dd142d91066cc1f8
Gerrit-Change-Number: 9406
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2291 (part 7): fix race in stack trace collection
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has removed a vote on this change.
Change subject: KUDU-2291 (part 7): fix race in stack trace collection
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id1af0ffa02efb8151f1f3f84dd142d91066cc1f8
Gerrit-Change-Number: 9406
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2291 (part 7): fix race in stack trace collection
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9406 )
Change subject: KUDU-2291 (part 7): fix race in stack trace collection
......................................................................
Patch Set 1: Verified+1
Going to address the IWYU issue separately to avoid having to rebase the world
--
To view, visit http://gerrit.cloudera.org:8080/9406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1af0ffa02efb8151f1f3f84dd142d91066cc1f8
Gerrit-Change-Number: 9406
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 23 Feb 2018 02:37:09 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2291 (part 7): fix race in stack trace collection
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9406 )
Change subject: KUDU-2291 (part 7): fix race in stack trace collection
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1af0ffa02efb8151f1f3f84dd142d91066cc1f8
Gerrit-Change-Number: 9406
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 23 Feb 2018 02:05:01 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2291 (part 7): fix race in stack trace collection
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9406 )
Change subject: KUDU-2291 (part 7): fix race in stack trace collection
......................................................................
KUDU-2291 (part 7): fix race in stack trace collection
This fixes a narrow race in which StackTraceCollector could return
'TimedOut' but in fact the stack trace would have been collected.
See the comments for details.
Change-Id: Id1af0ffa02efb8151f1f3f84dd142d91066cc1f8
Reviewed-on: http://gerrit.cloudera.org:8080/9406
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/util/debug-util.cc
M src/kudu/util/debug-util.h
2 files changed, 19 insertions(+), 8 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Todd Lipcon: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1af0ffa02efb8151f1f3f84dd142d91066cc1f8
Gerrit-Change-Number: 9406
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>